Merged
Conversation
|
Collaborator
Author
|
I now realize this was stupid... It does not make any difference what so ever if you load using import torch or e.g. torch.cuda, for what is actually loaded. So I don't think these changes were a good idea, since they might result in unnecessary confusion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used to have a lot of import torch happening in MS2DeepScore.
Particularly when working on a server doing the first import for ms2deepscore takes endlessly (sometimes multiple minutes). I think this might be due to this importing of the full torch. Hopefully this resolves it.
Locally the initializing of my tests already seems a lot faster (before this took often as long as the actual running)
I now realize this was stupid... It does not make any difference what so ever if you load using import torch or e.g. torch.cuda, for what is actually loaded. So I don't think these changes were a good idea, since they might result in unnecessary confusion. however, I already created a new release, so I don't think I will revert back