Default to a non-animated version of oops.gif#9549
Closed
ClearlyClaire wants to merge 3 commits intomastodon:masterfrom
Closed
Default to a non-animated version of oops.gif#9549ClearlyClaire wants to merge 3 commits intomastodon:masterfrom
ClearlyClaire wants to merge 3 commits intomastodon:masterfrom
Conversation
Contributor
Author
|
I guess we could, for the non-static part. But most of the time, such pages will show up because the server itself is down, and that lookup cannot be done in such occasions. |
Contributor
Author
|
Updated the PR to respect the autoPlayGif setting when it's available (and default to the still image otherwise) |
ClearlyClaire
force-pushed
the
fixes/blinking-500
branch
from
331da31 to
64fb201
Compare
koyuawsmbrtn
approved these changes
Dec 18, 2018
Contributor
koyuawsmbrtn
left a comment
koyuawsmbrtn
left a comment
There was a problem hiding this comment.
Looks pretty good, I don't know if it's ready to merge, but I would approve it
app/views/layouts/error.html.haml
Outdated
| %body.error | ||
| .dialog | ||
| %img{ alt: Setting.default_settings['site_title'], src: '/oops.gif' }/ | ||
| %img{ alt: Setting.default_settings['site_title'], src: '/oops.png' }/ |
Contributor
There was a problem hiding this comment.
What about trying to get the value from the settings saying "allow autoplay" and then animate it if the user wishes so? It's also disabled by default so it shouldn't bother anyone.
renatolond
approved these changes
Dec 20, 2018
danhunsaker
approved these changes
Dec 22, 2018
danhunsaker
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6060
The new png is the first frame from the animated gif, with the orange bits removed since they only make sense in the animation.