Skip to content

Put the CW field between the toot we are replying to and the toot field#7508

Merged
Gargron merged 3 commits intomastodon:masterfrom
ariasuni:move-cw-field
May 31, 2018
Merged

Put the CW field between the toot we are replying to and the toot field#7508
Gargron merged 3 commits intomastodon:masterfrom
ariasuni:move-cw-field

Conversation

@ariasuni
Copy link
Copy Markdown
Contributor

As explained in #1326, users may be confused by or forget about the CW field automatically field with the CW of the toot they are replying to; notably, the CW field may be very far away or no longer be visible when the toot is long.

The solution I propose is to put the CW field just above the toot being composed itself, so it’s always clear that there’s a CW (or not). It’s also more logical to put the CW nearer the toot than the toot being replied to.

Screenshots before/after:

screenshot_2018-05-16 mastodon devscreenshot_2018-05-16 mastodon dev after

Copy link
Copy Markdown
Contributor

@ClearlyClaire ClearlyClaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove the Collapsable component/animation?

@Gargron
Copy link
Copy Markdown
Member

Gargron commented May 16, 2018

Spacing looks wrong.

@ariasuni
Copy link
Copy Markdown
Contributor Author

@ThibG The Collapsable was basically putting style/appearance in the logic instead of the CSS, in a much verbose and less understandable way. Also, now changing margins happens in one place, which makes changing default theme/theming easier.

@Gargron My reasoning was that as the CW is part of the toot, the margin between the CW field and the toot field should be thinner. I can make both margin the same size, if you like it better this way.

@ClearlyClaire
Copy link
Copy Markdown
Contributor

@Gargron up? Do you still think the spacing needs change? Are there other issues with that PR?

@Gargron
Copy link
Copy Markdown
Member

Gargron commented May 22, 2018

Yes, I do think the spacing needs change.

@Gargron
Copy link
Copy Markdown
Member

Gargron commented May 22, 2018

I also haven't seen how the animation looks now. I'm not so sure: spring-based animation is generally more interesting to look at than CSS transitions. I do not agree with the arguments about style in the markup, we use Motion throughout the application so it's more consistent for us to have that than CSS transitions.

@ariasuni
Copy link
Copy Markdown
Contributor Author

The problem I had with height of the element in the markup is that I couldn’t modify the size of the spacing under the CW easily with my custom CSS extension (I assume it’s the same for themes).

@ariasuni
Copy link
Copy Markdown
Contributor Author

ariasuni commented May 31, 2018

Here’s how it looks now (before/after):

screenshot_2018-05-16 mastodon devscreenshot_2018-05-31 mastodon dev

I used the same 10px spacing that’s used between the toot field and the toot button.

@ariasuni
Copy link
Copy Markdown
Contributor Author

I also kept the CSS animation, since I didn’t notice any difference visible difference with the Spring one, and for the easier theming of margins.

@Gargron Gargron merged commit 6911072 into mastodon:master May 31, 2018
lawremipsum pushed a commit to lawremipsum/mspsocial-mastodon that referenced this pull request Jul 7, 2018
…eld (mastodon#7508)

* Remove Collapsable and use CSS instead

* Put the CW field between the toot we are replying to and the toot field

* Use same spacing between all fields in the composing column
@ariasuni ariasuni deleted the move-cw-field branch June 25, 2020 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants