Put the CW field between the toot we are replying to and the toot field#7508
Put the CW field between the toot we are replying to and the toot field#7508Gargron merged 3 commits intomastodon:masterfrom
Conversation
ClearlyClaire
left a comment
There was a problem hiding this comment.
Why remove the Collapsable component/animation?
|
Spacing looks wrong. |
|
@ThibG The Collapsable was basically putting style/appearance in the logic instead of the CSS, in a much verbose and less understandable way. Also, now changing margins happens in one place, which makes changing default theme/theming easier. @Gargron My reasoning was that as the CW is part of the toot, the margin between the CW field and the toot field should be thinner. I can make both margin the same size, if you like it better this way. |
|
@Gargron up? Do you still think the spacing needs change? Are there other issues with that PR? |
|
Yes, I do think the spacing needs change. |
|
I also haven't seen how the animation looks now. I'm not so sure: spring-based animation is generally more interesting to look at than CSS transitions. I do not agree with the arguments about style in the markup, we use Motion throughout the application so it's more consistent for us to have that than CSS transitions. |
|
The problem I had with height of the element in the markup is that I couldn’t modify the size of the spacing under the CW easily with my custom CSS extension (I assume it’s the same for themes). |
|
I also kept the CSS animation, since I didn’t notice any difference visible difference with the Spring one, and for the easier theming of margins. |
…eld (mastodon#7508) * Remove Collapsable and use CSS instead * Put the CW field between the toot we are replying to and the toot field * Use same spacing between all fields in the composing column


As explained in #1326, users may be confused by or forget about the CW field automatically field with the CW of the toot they are replying to; notably, the CW field may be very far away or no longer be visible when the toot is long.
The solution I propose is to put the CW field just above the toot being composed itself, so it’s always clear that there’s a CW (or not). It’s also more logical to put the CW nearer the toot than the toot being replied to.
Screenshots before/after: