Skip to content

#255 – Collapsable toots!#658

Closed
marrus-sh wants to merge 4 commits intomastodon:masterfrom
marrus-sh:mastodon-reduced-toots
Closed

#255 – Collapsable toots!#658
marrus-sh wants to merge 4 commits intomastodon:masterfrom
marrus-sh:mastodon-reduced-toots

Conversation

@marrus-sh
Copy link
Copy Markdown
Contributor

Automatically collapses toots in timelines whose text contents are taller than 200px tall, with a button at the bottom to expand. Doesn't look at toots with spoiler/content warnings, so hypothetically if someone really wanted to fill up your feed with long toots they could abuse that. I don't really see that being a problem though.

@yiskah
Copy link
Copy Markdown
Contributor

yiskah commented Mar 2, 2017

I imagine this would solve the problem of encountering instances without character limits posting entire articles as well?

@yiskah
Copy link
Copy Markdown
Contributor

yiskah commented Mar 31, 2017

Hey @Gargron is this Pull mergable right now? It would help address some of the harassment/spamming concerns that have been brought up in relation to someone making instances for the purpose of spamming. Since a post could not be too long if collapsed.

@MyMothersHairdresser
Copy link
Copy Markdown

With the recent influx of new users remarking on the prevalence of bots, I dug through my blocklist- plenty of the ones I've blocked are blocked because they just post immense toots.

This pull is exceedingly relevant to new users and will help with harassment in the future; is there any technical reason why this has not been already merged?
Thanks!

@sethmlarson
Copy link
Copy Markdown

This feature is desperately needed.


handleCollapsedClick (e) {
e.preventDefault();
this.setState({ collapsed: !this.state.collapsed });
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this setting collapsed to !null? Does that result in false? A little unsure of the value flow here.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It flips the boolean. If collapsed is null, it will set collapsed to true as null is falsey.
However, as handleCollapsedClick only is used when collapsed is not null that case wont happen.

@ineffyble ineffyble requested a review from Gargron April 8, 2017 13:06
@Gargron Gargron added the ui Front-end, design label Apr 8, 2017
@dcl
Copy link
Copy Markdown

dcl commented Apr 12, 2017

Hey, what's the status on getting this merged?

@yiskah yiskah assigned yiskah, Gargron and blackle and unassigned yiskah Apr 12, 2017
@yiskah
Copy link
Copy Markdown
Contributor

yiskah commented Apr 12, 2017

We need it to be reviewed by probably gargron before merging

@ashfurrow
Copy link
Copy Markdown
Contributor

@marrus-sh thanks for the pull request! Sorry it's bene hanging around with no resolution. It looks like there are a few merge conflicts. Would you be able to pull from latest and review the changes? There are a few CodeClimate issues to resolve too. Then we can ping Gargron and see about getting this merged. Thanks again!

@progval progval mentioned this pull request Jun 15, 2017
abcang added a commit to pixiv/mastodon that referenced this pull request Nov 15, 2017
alarixnia pushed a commit to alarixnia/mastofe that referenced this pull request Sep 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ui Front-end, design

Projects

None yet

Development

Successfully merging this pull request may close these issues.