Set false to animated options for thumbnail processor#4547
Merged
Gargron merged 1 commit intomastodon:masterfrom Aug 7, 2017
ykzts:animated-false
Merged
Set false to animated options for thumbnail processor#4547Gargron merged 1 commit intomastodon:masterfrom ykzts:animated-false
Gargron merged 1 commit intomastodon:masterfrom
ykzts:animated-false
Conversation
Resolve #3199 Fix the aspect ratio of animated GIF whose background is transparent.
Gargron
approved these changes
Aug 7, 2017
Contributor
|
I experienced glitch that static version of animated icon is not shown. |
Member
|
Hmm, you are right. I forgot that paperclip just assumes the format specified in the style is the extension. I don't want to force people to regenerate everything... |
Member
Author
|
I forgot that this also applies to past things... Requiring regeneration would be a hassle for instance administrators. |
Member
Author
|
I think that it is better to revert. #4550 I will consider a better way. |
Gargron
pushed a commit
that referenced
this pull request
Aug 7, 2017
* Revert "Adjust tags and accounts page (#4534)" This reverts commit a3e53bd. * Revert "feat: Cache status height to avoid expensive renders (#4439)" This reverts commit 8eb6d17. * Revert "Refactor Avatar and AvatarOverlay to have 'account' as prop instead of src and staticSrc (#4526)" This reverts commit 5942347. * Revert "Update dependencies for Ruby (#4543)" This reverts commit 22db947. * Revert "[Docker] Add multicore support to "make" and "bundler" (#4544)" This reverts commit 5d408fd. * Revert "It makes no sense to try using invalid or expired link again (#4521)" This reverts commit 47579ec. * Revert "i18n: Update Polish translation (#4545)" This reverts commit 3363a05. * Revert "Set false to animated options for thumbnail processor (#4547)" This reverts commit 87f10d4.
This was referenced Aug 7, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #3199
Fix the aspect ratio of animated GIF whose background is transparent.