Use GNU libiconv in Nokogiri#4494
Merged
Gargron merged 1 commit intomastodon:masterfrom Aug 3, 2017
ykzts:libiconv
Merged
Conversation
ykzts
commented
Aug 2, 2017
Dockerfile
Outdated
Member
Author
There was a problem hiding this comment.
libxml2 and libxslt will be downloaded during Nokogiri installation.
Contributor
|
I also use GNU Libiconv in some of my Docker images for that reason. So +1 for this. |
Member
Author
|
@Wonderfall Thank you for review! |
Contributor
|
The I tried myself (https://github.com/Wonderfall/dockerfiles/blob/master/mastodon/Dockerfile.targaryen#L60-L65), this change is working. +1 for merging! |
Member
Author
|
@Wonderfall Okay! Thx😚 |
System default libiconv of Alpine Linux only supports some charset (e.g. UTF-8). Therefore, the preview card of the page which is not UTF-8 will be broken in the Docker environment. Using GNU libiconv!
Gargron
approved these changes
Aug 3, 2017
pfigel
added a commit
to pfigel/mastodon
that referenced
this pull request
Aug 7, 2017
* tag 'v1.5.1': (25 commits) Bump to 1.5.1 i18n: update Persian translation (mastodon#4540) Fix mastodon#4531 (mastodon#4533) fr.yml update (mastodon#4531) Translate 'Signed in as' into Japanese (mastodon#4530) l10n OC - Added mastodon#4523 "signed in as" (mastodon#4529) fix columns_area.js (mastodon#4528) Update goldfinger to 2.0.1, see mastodon/goldfinger#5 (mastodon#4527) Add "signed in as" header to some pages (mastodon#4523) l10n update Occitan (mastodon#4522) Scroll columns area to right when children property is changed (mastodon#4517) Fix some mistakes in Polish translation (mastodon#4495) Ignore some locale keys that can but do not need to be translated (mastodon#4515) Dutch strings: typo (mastodon#4489) Use GNU libiconv in Nokogiri (mastodon#4494) i18n: Update Polish translation (mastodon#4479) Enable cache for babel-loader (mastodon#4505) Redirect to PasswordController#new when reset_password_token is invalid (mastodon#4506) make number of comparison in emojify() fewer (mastodon#4500) Don't normalize invalid domain names (mastodon#4499) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
System default libiconv of Alpine Linux only supports some charset (e.g. UTF-8). Therefore, the preview card of the page which is not UTF-8 will be broken in the Docker environment.
Solve using GNU libiconv.