Skip to content

Dutch strings: typo#4489

Merged
ykzts merged 1 commit intomasterfrom
unknown repository
Aug 3, 2017
Merged

Dutch strings: typo#4489
ykzts merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Aug 1, 2017

No description provided.

Comment thread config/locales/nl.yml
applications:
invalid_url: De opgegeven URL is ongeldig
auth:
agreement_html: Wanneer je op registeren klikt ga je akkoord met <a href="%{rules_path}">onze gebruikersvoorwaarden</a> en <a href="%{terms_path}">ons privacybeleid</a>.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ykzts What is the issue?

I only corrected a previous typo. 'registeren' to 'registreren'

Copy link
Copy Markdown
Member

@ykzts ykzts Aug 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a note. I don't know Dutch.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ykzts Why are you asking another Dutch speaker for me fixing a simple typo?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ykzts I am a native Dutch speaker and I translated 99% of Mastodon. Actually I fixed my own typo. So hopefully you understand I find this very strange.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm checking *.nl.yml and nl.json now. I saw you translating the majority of parts. I do not think this is a problem, but I also want other people's opinions.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Another people's opinion' for a (self-made) typo?

'registeren' is not a word. 'Registreren' is. It means in English 'to register' (an account). I asked @Gargron to come here, cause I find this not very productive.

@ykzts ykzts added the l10n label Aug 1, 2017
@ykzts
Copy link
Copy Markdown
Member

ykzts commented Aug 2, 2017

cc @Fjoerfoks

@nightpool
Copy link
Copy Markdown
Member

@jeroenpraat Hi Jeroen. Recently, we're trying to hold our translations to a higher quality by requiring at least one fluent speaker of the language to double-check them before we merge them into the repo. While I understand this seems like a difficult change, this is a much less strict standard then we hold any other type of contribution to. If you can get any other Dutch speaker with a github account to take a look at this pull request and leave a comment indicating that they're happy with it, that's good enough for us.

We're just trying to prevent typos like this from showing up in the first place!

@ghost
Copy link
Copy Markdown
Author

ghost commented Aug 3, 2017

@nightpool This will not work, maybe for languages with a lot of Mastodon users, but not Dutch or any other language with a low user count on Mastodon. This will frustrate or even hold up translations. Now I see there is someone cc't that is not even using Mastodon. The only solution to achieve what you want is to use a 3rd party translation service.

I also have problems about the fact this is not communicated with translators at all. Or maybe this because we we don't have a good list with translators, but that is because we don't use a separate service for translations. The chicken and the egg.

Until this is solved, I won't add my translations to Github anymore, but only directly to my instance @ todon.nl. When Mastodon will use a 3rd party service, I will be glad to add it there.

@nightpool
Copy link
Copy Markdown
Member

@jeroenpraat I'm going to look into setting up weblate this weekend.

But if there are at least two users for any given language, then I don't see the problem with having one of them checking the other's work. I don't see why this would be more of a problem on github vs on a third party service like weblate?

@ghost
Copy link
Copy Markdown
Author

ghost commented Aug 3, 2017

@nightpool That will only work if there are at least two (Dutch) users on Weblate. If there is only one, you have to trust that person or ignore the translation completely. If I am over there still the only one, the Mastodon devs can choose to trust me or choose not to update the Dutch translation. But don't cc some random Github user for a simple typo fix (I made myself).

@ghost
Copy link
Copy Markdown
Author

ghost commented Aug 3, 2017

@nightpool Also something like Weblate or Transifex is more accessible for non-developers.

@nightpool
Copy link
Copy Markdown
Member

nightpool commented Aug 3, 2017

It wasn't a random github user, it was a user who had previously contributed Dutch translations to the repo.

Anyway, yes. this argument is stupid to have about a one-character typo fix. practicality > purity.

@ghost
Copy link
Copy Markdown
Author

ghost commented Aug 3, 2017

@nightpool Thanks.

@ykzts ykzts merged commit 76da330 into mastodon:master Aug 3, 2017
pfigel added a commit to pfigel/mastodon that referenced this pull request Aug 7, 2017
* tag 'v1.5.1': (25 commits)
  Bump to 1.5.1
  i18n: update Persian translation (mastodon#4540)
  Fix mastodon#4531 (mastodon#4533)
  fr.yml update (mastodon#4531)
  Translate 'Signed in as' into Japanese (mastodon#4530)
  l10n OC - Added  mastodon#4523 "signed in as" (mastodon#4529)
  fix columns_area.js (mastodon#4528)
  Update goldfinger to 2.0.1, see mastodon/goldfinger#5 (mastodon#4527)
  Add "signed in as" header to some pages (mastodon#4523)
  l10n update Occitan (mastodon#4522)
  Scroll columns area to right when children property is changed (mastodon#4517)
  Fix some mistakes in Polish translation (mastodon#4495)
  Ignore some locale keys that can but do not need to be translated (mastodon#4515)
  Dutch strings: typo (mastodon#4489)
  Use GNU libiconv in Nokogiri (mastodon#4494)
  i18n: Update Polish translation (mastodon#4479)
  Enable cache for babel-loader (mastodon#4505)
  Redirect to PasswordController#new when reset_password_token is invalid (mastodon#4506)
  make number of comparison in emojify() fewer (mastodon#4500)
  Don't normalize invalid domain names (mastodon#4499)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants