Skip to content

Re-add outline#4474

Merged
Gargron merged 2 commits intomastodon:masterfrom
ykzts:readd-outline
Jul 31, 2017
Merged

Re-add outline#4474
Gargron merged 2 commits intomastodon:masterfrom
ykzts:readd-outline

Conversation

@ykzts
Copy link
Copy Markdown
Member

@ykzts ykzts commented Jul 31, 2017

ref #4448

I actually tried it and felt that the style with DM was confusing. This Pull Request rewinds the previous change, making Google Chrome and Firefox look the same.

before (Firefox v54)

after

@ykzts ykzts added the ui Front-end, design label Jul 31, 2017
@Gargron
Copy link
Copy Markdown
Member

Gargron commented Jul 31, 2017

I kind of agree, but I also don't like the blue outline vs the default one. Because all other elements on the page have a standard outline, and only a couple elements have the blue one.

@ykzts
Copy link
Copy Markdown
Member Author

ykzts commented Jul 31, 2017

@Gargron Respect the original of the web browser c428829.

To unify all other parts with a blue outline has many changes and it is serious. I withdraw the original Pull Request.

@Gargron Gargron merged commit 8ccb3b9 into mastodon:master Jul 31, 2017
@ykzts ykzts deleted the readd-outline branch July 31, 2017 23:49
pfigel added a commit to pfigel/mastodon that referenced this pull request Aug 3, 2017
* tag 'v1.5.0': (333 commits)
  Bump to 1.5.0
  Update Dutch (nl) strings (mastodon#4480)
  Show SMTP_TLS in config sample (mastodon#4477)
  fix(web_push_notifications): Send message with welcome notifications (mastodon#4471)
  Change logo URL for Heroku and Scalingo (mastodon#4476)
  Add libidn11 to Aptfile (mastodon#4475)
  Re-add outline (mastodon#4474)
  do not emojify tm, (R) and (C) (mastodon#4472)
  i18n: update Persian translation (mastodon#4470)
  Load extra polyfills when isIntersecting is undefined (mastodon#4469)
  Bump to 1.5.0rc3
  Simplify web UI character counter logic (mastodon#4463)
  Fix button overflow on confirmation modal for mobile (mastodon#4465)
  Change RuboCop rules to loose (mastodon#4464)
  i18n: Update Polish translation (mastodon#4467)
  Disable sensitive button when with content warnings (mastodon#4460)
  Fix length validator counting things that look like URIs like URLs (mastodon#4462)
  Make salutation of email localizable (mastodon#4454)
  Improve accessibility (part 7) (mastodon#4457)
  Change to sensitive when adding content warning from web UI (mastodon#4456)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ui Front-end, design

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants