Add "Mute conversation" button to statuses everywhere#4473
Closed
MightyPork wants to merge 1 commit intomastodon:masterfrom
Closed
Add "Mute conversation" button to statuses everywhere#4473MightyPork wants to merge 1 commit intomastodon:masterfrom
MightyPork wants to merge 1 commit intomastodon:masterfrom
Conversation
Contributor
|
for the record: i requested this! i've mentioned it several times in other places (including on mastodon of course) and others always expressed interest in it as well, so i asked piggo to submit this PR here rather than at the fork. |
Member
|
my problem with this is that the copy doesn't make it clear it only will hide a conversation from your notifications—it doesn't do anything about, say, seeing it in your home timeline this was slightly mitigated by the fact that the button only showed up in the notification box in the first place, but this change causes it to become more confusing. |
Contributor
|
oh well that's legit AF, i thought it did that also. sigh |
Contributor
|
mmm maybe i will pull this to glitch.social and modify the back end then we can re-submit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the withDismiss attribute from StatusActionBar so the option to mute a conversation is accessible everywhere without having to hunt for a notification.