fix(web_push_notifications): Send message with welcome notifications#4471
Merged
Gargron merged 2 commits intomastodon:masterfrom Aug 1, 2017
sorin-davidoi:fix-notifications-grouping
Merged
fix(web_push_notifications): Send message with welcome notifications#4471Gargron merged 2 commits intomastodon:masterfrom sorin-davidoi:fix-notifications-grouping
Gargron merged 2 commits intomastodon:masterfrom
sorin-davidoi:fix-notifications-grouping
Conversation
Contributor
Author
|
@beatrix-bitrot This was why grouping would fail on Android 😞 |
Gargron
approved these changes
Aug 1, 2017
|
@sorin-davidoi Would this require resubscribing, or should it fix already existing subscriptions too? |
Contributor
Author
|
It should fix them as soon as the next one comes. |
|
Great, thanks. :) |
Contributor
Author
|
I think when the first one comes it will be grouped together with the previous notifications - even if those were dismissed. This is a bug in the Android implementation, but this should work around that. |
pfigel
added a commit
to pfigel/mastodon
that referenced
this pull request
Aug 3, 2017
* tag 'v1.5.0': (333 commits) Bump to 1.5.0 Update Dutch (nl) strings (mastodon#4480) Show SMTP_TLS in config sample (mastodon#4477) fix(web_push_notifications): Send message with welcome notifications (mastodon#4471) Change logo URL for Heroku and Scalingo (mastodon#4476) Add libidn11 to Aptfile (mastodon#4475) Re-add outline (mastodon#4474) do not emojify tm, (R) and (C) (mastodon#4472) i18n: update Persian translation (mastodon#4470) Load extra polyfills when isIntersecting is undefined (mastodon#4469) Bump to 1.5.0rc3 Simplify web UI character counter logic (mastodon#4463) Fix button overflow on confirmation modal for mobile (mastodon#4465) Change RuboCop rules to loose (mastodon#4464) i18n: Update Polish translation (mastodon#4467) Disable sensitive button when with content warnings (mastodon#4460) Fix length validator counting things that look like URIs like URLs (mastodon#4462) Make salutation of email localizable (mastodon#4454) Improve accessibility (part 7) (mastodon#4457) Change to sensitive when adding content warning from web UI (mastodon#4456) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the format message was not sent with the first notification, grouping would fail. This includes the message in the payload for the welcome notification, but also reads it from the last notification (to avoid reading the misconfigured one).