Skip to content

Improve accessibility (part 3)#4405

Merged
Gargron merged 16 commits intomastodon:masterfrom
sorin-davidoi:improve-accessibility-3
Jul 27, 2017
Merged

Improve accessibility (part 3)#4405
Gargron merged 16 commits intomastodon:masterfrom
sorin-davidoi:improve-accessibility-3

Conversation

@sorin-davidoi
Copy link
Copy Markdown
Contributor

@sorin-davidoi sorin-davidoi commented Jul 27, 2017 •
edited
Loading

Follow-up to #4369 and #4377. Mostly fixes errors discovered by WAVE Web Accessibility Tool.

cc: @yiskah

@sorin-davidoi
Copy link
Copy Markdown
Contributor Author

sorin-davidoi commented Jul 27, 2017

I think the warnings are wrong? input is inside label (which is what WAVE Web Accessibility Tool suggests).

@sorin-davidoi sorin-davidoi changed the title Improve accessibility 3 Improve accessibility (part 3) Jul 27, 2017
@unarist
Copy link
Copy Markdown
Contributor

unarist commented Jul 27, 2017

Looks like it was fixed last month? https://github.com/evcohen/eslint-plugin-jsx-a11y/releases/tag/v6.0.0

unarist
unarist reviewed Jul 27, 2017
View reviewed changes
app/javascript/mastodon/components/column_header.js Outdated
Copy link
Copy Markdown
Contributor

@unarist unarist Jul 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's heading element now, so role='heading' can be removable.

@Gargron
Copy link
Copy Markdown
Member

Gargron commented Jul 27, 2017

Form controls using a label to identify them must be programmatically associated with the control using htmlFor

Hwhat?

@sorin-davidoi
Copy link
Copy Markdown
Contributor Author

sorin-davidoi commented Jul 27, 2017 •
edited
Loading

Should I just silence the errors for now? Silenced.

I've added the inert attribute to the siblings of modal-root when it is opened. I'm deliberately not including the polyfill because I didn't test it's performance (relies on mutation observers) - it has no effect in browsers that don't support it.

@Gargron Gargron merged commit 6884dd7 into mastodon:master Jul 27, 2017
@sorin-davidoi sorin-davidoi deleted the improve-accessibility-3 branch July 27, 2017 22:56
This was referenced Jul 28, 2017
Merged
Merged
Gargron pushed a commit that referenced this pull request Jul 28, 2017
@ykzts @Gargron
Fix column header in landing page (regression from #4405) (#4416)
62a9da6
@yiskah
Copy link
Copy Markdown
Contributor

yiskah commented Jul 28, 2017

<3 you're the best sorin

@sorin-davidoi sorin-davidoi mentioned this pull request Jul 28, 2017
Merged
hcmiya pushed a commit to hcmiya/v6don that referenced this pull request Jul 29, 2017
@sorin-davidoi @hcmiya
Improve accessibility (part 3) (mastodon#4405)
fd06b5e 
* fix(compose): Add aria-label for the navigation links

* fix(search): Add input label

* fix(navigation_bar): Link description

* fix(autosuggest_textarea): Add input label

* fix(compose_form): Add input label

* fix(upload_button): Add input label

* fix(account/header): Add link content

* fix(column_header): Use h1 tag

* fix(column_header): Labels move buttons moving column

* fix(settings_text): Add label to input

* fix(column_header): Remove role from h1

* fix(modal_root): Use role=dialog

* fix(modal_root): Focus restauration

* fix(modal_root): Apply inert to sibligs

* fix(column_header): Add role=button

* chore(eslint): Disable jsx-a11y/label-has-for
hcmiya pushed a commit to hcmiya/v6don that referenced this pull request Jul 29, 2017
@ykzts @hcmiya
Fix column header in landing page (regression from mastodon#4405) (ma…
b106a57 
…stodon#4416)
@sorin-davidoi sorin-davidoi mentioned this pull request Jul 30, 2017
Merged
@sorin-davidoi sorin-davidoi mentioned this pull request Dec 16, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gargron Gargron Gargron approved these changes

+1 more reviewer

@unarist unarist unarist left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sorin-davidoi @unarist @Gargron @yiskah