Skip to content

Change logo.png to logo.svg for web UI (regression from #4306)#4307

Merged
Gargron merged 1 commit intomastodon:masterfrom
ykzts:rm-logo-png
Jul 23, 2017
Merged

Change logo.png to logo.svg for web UI (regression from #4306)#4307
Gargron merged 1 commit intomastodon:masterfrom
ykzts:rm-logo-png

Conversation

@ykzts
Copy link
Copy Markdown
Member

@ykzts ykzts commented Jul 23, 2017 

  1) Log in A valid email and password user is able to log in
     Failure/Error: = image_tag asset_pack_path('logo.png')
     
     ActionView::Template::Error:
       Can't find logo.png in /home/travis/build/tootsuite/mastodon/public/packs-test/manifest.json. Is webpack still compiling?
     # ./app/views/home/index.html.haml:9:in `_app_views_home_index_html_haml__1361396113722584969_91733700'
     # ./spec/features/log_in_spec.rb:18:in `block (2 levels) in <top (required)>'
     # ------------------
     # --- Caused by: ---
     # Webpacker::FileLoader::NotFoundError:
     #   Can't find logo.png in /home/travis/build/tootsuite/mastodon/public/packs-test/manifest.json. Is webpack still compiling?
     #   ./app/views/home/index.html.haml:9:in `_app_views_home_index_html_haml__1361396113722584969_91733700'

@ykzts ykzts added the bug Something isn't working label Jul 23, 2017
@MightyPork
Copy link
Copy Markdown
Contributor

MightyPork commented Jul 23, 2017

While we're at it, there are two dead links in app.json and scalingo.json pointing to https://github.com/tootsuite/mastodon/raw/master/app/assets/images/logo.png which is long gone, maybe you could change those as well

@MightyPork MightyPork mentioned this pull request Jul 23, 2017
Merged
@Gargron Gargron merged commit 4d661e1 into mastodon:master Jul 23, 2017
@ykzts ykzts deleted the rm-logo-png branch July 24, 2017 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gargron Gargron Gargron approved these changes

+1 more reviewer

@amithm7 amithm7 amithm7 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ykzts @MightyPork @Gargron @amithm7