Merged
Conversation
When we are only interested in the normalized host, calling normalized_host avoids normalizing the other components of the URI as well as creating a new object
Gargron
approved these changes
Jul 15, 2017
Member
|
Note: I had to install |
Contributor
|
Yep same, needs to go in update guide/notes!
…On Sat, Jul 15, 2017, 6:13 PM Eugen Rochko, ***@***.***> wrote:
Note: I had to install libidn11-dev on my Ubuntu 16.04 to get ruby-idn to
install.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#4212 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA2AQcYGkF6kn1QzoiJ_Zdp847lGnGSjks5sOTmIgaJpZM4OZCUg>
.
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor optimizations out of my previous “fix-push” PR request (now obsolete) that heavily used URI normalization.
While it provided a ×5 speed-up in that situation, there should be no single task in Mastodon making such heavy use of URI normalization, so the benefits are not that obvious.
Nevertheless, URI normalization happens frequently in Mastodon, so this should contribute to reducing Mastodon's CPU usage overall.