Skip to content

fix(components/media_modal): Style issues#4187

Merged
Gargron merged 1 commit intomastodon:masterfrom
sorin-davidoi:media-modal-swipe
Jul 13, 2017
Merged

fix(components/media_modal): Style issues#4187
Gargron merged 1 commit intomastodon:masterfrom
sorin-davidoi:media-modal-swipe

Conversation

@sorin-davidoi
Copy link
Copy Markdown
Contributor

Fixes most of the issue described by @unarist here.

My CSS skills fail me at the following issue:

object-fit won't shrink element itself, so they can't close modal on clicking those margin. It confuses users especially on single image which doesn't have prev/next buttons.

If anyone has any input on fixing this one let me know and I'll include it here.

@lynlynlynx
Copy link
Copy Markdown
Contributor

lynlynlynx commented Jul 13, 2017

To deal with non shrinking modal on single image, I use this way.

But it is difficult for me to shrink modal on multiple images.
I have no idea to...

  • Get width of reduced image in each one
  • Change width of swipeable-view-container every time image is switched

@sorin-davidoi

@Gargron Gargron merged commit a9a0c85 into mastodon:master Jul 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants