codeclimate won't let me dismiss false positives, but in order:

• empty line at beginning of method is for docs (not sure if they're useful now that the code is more readable, but they're there)
• = operator spacing is to align with the +=/||= on the next line

rubocop says line 120, around which there is no +=, has an extra space.

@akihikodaki fixed

See 6fd865c

You're reverting deliberate optimizations - this code is a performance hot spot and we want it to handle as little information as possible, thus passing it an integer and not a full account, and using batched checks for mutes, blocks etc.

If I'm reading correctly the actual fix is the line return true if status.in_reply_to_account.nil? || status.in_reply_to_id.nil?, which in old code would be return true if status.reply? && (status.in_reply_to_account.nil? || status.in_reply_to_id.nil?)

@Gargron Since that code was written, the performance of muting?, blocking?, and following? have all been changed, and now the two alternatives create identical SQL queries, but one is much more readable and maintainable.

I'm not sure how passing an integer vs. a full account would change the performance in this case at all, seeing as everywhere we call it we are explicitly taking an id from a full activerecord object, and everywhere we compare it we're still using the ID—the only difference is the muting? and blocking? calls.

I also moved the blocking calls to after the "reply?" check for performance reasons (do the easy checks first) but i'm down to revert that if you think it's a bad idea.