Conversation
Member
Author
|
Benchmark: s = Status.last
Benchmark.ms { 1000.times { InlineRenderer.render(s, nil, 'api/v1/statuses/show') } }vs. s = Status.last
Benchmark.ms { 1000.times { InlineRenderer.render(s, nil, :status) } }Old (Rabl): 2138.066630999674ms |
Gargron
force-pushed
the
feature-refactor-json-templates
branch
from
f02c3b3 to
6126a5b
Compare
ykzts
approved these changes
Jul 7, 2017
Member
|
This PR may be broken. $ curl -sS -H"Authorization: Bearer ${MASTODON_ACCESS_TOKEN}" http://localhost:3000/api/v1/statuses/29 | jq '.'
{
"id": 29,
"created_at": "2017-07-07T06:24:50.062Z",
"in_reply_to_id": null,
"in_reply_to_account_id": null,
"sensitive": false,
"spoiler_text": "",
"visibility": "public",
"language": null,
"uri": "tag:localhost:3000,2017-07-07:objectId=29:objectType=Status",
"content": "<p>RT <span class=\"h-card\"><a href=\"http://localhost:3000/@ykzts\" class=\"u-url mention\">@<span>ykzts</span></a></span> a</p>",
"url": "http://localhost:3000/@ykzts/29",
"reblogs_count": 0,
"favourites_count": 0,
"favourited": false,
"reblogged": true,
"muted": false,
"reblog": {
"id": 28,
"created_at": "2017-07-07T06:24:44.848Z",
"in_reply_to_id": null,
"in_reply_to_account_id": null,
"sensitive": false,
"spoiler_text": "",
"visibility": "public",
"language": "lb",
"uri": "tag:localhost:3000,2017-07-07:objectId=28:objectType=Status",
"content": "<p>a</p>",
"url": "http://localhost:3000/@ykzts/28",
"reblogs_count": 1,
"favourites_count": 0,
"favourited": false,
"reblogged": true,
"muted": false
},
"application": null,
"account": {
"id": 2,
"username": "ykzts",
"acct": "ykzts",
"display_name": "",
"locked": false,
"created_at": "2017-07-07T05:17:04.201Z",
"note": "<p></p>",
"url": "http://localhost:3000/@ykzts",
"avatar": "http://localhost:3000/avatars/original/missing.png",
"avatar_static": "http://localhost:3000/avatars/original/missing.png",
"header": "http://localhost:3000/headers/original/missing.png",
"header_static": "http://localhost:3000/headers/original/missing.png",
"followers_count": 1,
"following_count": 1,
"statuses_count": 15
},
"media_attachments": [],
"mentions": [],
"tags": []
}missing |
Contributor
|
#4095 was merged, but |
Gargron
added a commit
that referenced
this pull request
Jul 7, 2017
* Restore streaming API output format Regression from #4090 * Remove whitespace
Contributor
|
Maybe this PR ignores |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
I have not yet managed to completely remove Rabl as a dependency. "Initial state" and OEmbed responses, as well as the old ActivityPub stuff that will be replaced still uses Rabl.