Don't use locked state as default privacy setting in anywhere#4082
Don't use locked state as default privacy setting in anywhere#4082unarist wants to merge 1 commit intomastodon:masterfrom
Conversation
Currently we set *default post privacy* for locked account to "private". However, it only means: * default value for `visibility` option on post status API * default value for default privacy setting on web UI i.e. it makes no sense if the client specifies (own default) visibility option, or the user already set default privacy setting. This may confuse users. This removes the hint text about this from Profile page, and current usages for consistency.
|
Oops, this must be fixed since this actually changes default privacy setting of locked accounts. It needs some migration if we will go with current implementation. |
|
This feels like throwing out the baby with the bathwater... why not just merge #4075? That feels like a much much simpler solution |
|
@nightpool Providing default privacy settings via API is also good, but main concern is below hint text.
I thought "defaults post privacy to followers-only" means changing default post privacy for web UI, but it's not correct. So I'm considering to take one of following options:
This PR took first option, but now I think second option might be better. |
|
Should we rethink this now that #4075 is merged? |
|
@Gargron Yeah. So, should account locking changes current settings only if they haven't configured (current behavior), or anytime? Users may not want to override their own settings, but override anytime seems understandable and easy to describe I think. |
3 participants
Currently we set default post privacy for locked account to "private". However, it only means:
visibilityoption on post status APIi.e. it makes no sense if the client specifies (own default) visibility option, or the user already set default privacy setting. This may confuse users.
This removes the hint text about this from Profile page, and current usages for consistency.
Other option: Set default privacy setting for web UI to "private" when the user locked account, and provide this value to clients, although clients may not respect that value.