Fix Vary parsing in cache control enforcement#37426
Merged
ClearlyClaire merged 1 commit intomastodon:mainfrom Jan 9, 2026
Merged
Fix Vary parsing in cache control enforcement#37426ClearlyClaire merged 1 commit intomastodon:mainfrom
ClearlyClaire merged 1 commit intomastodon:mainfrom
Conversation
Parse the Vary response header as a comma-separated list instead of splitting on whitespace, so tokens like "Authorization, Accept-Language" correctly match "authorization" and trigger private/no-store when sensitive request headers are present.
ClearlyClaire
approved these changes
Jan 9, 2026
ClearlyClaire
pushed a commit
that referenced
this pull request
Jan 16, 2026
ClearlyClaire
pushed a commit
that referenced
this pull request
Jan 16, 2026
ClearlyClaire
pushed a commit
that referenced
this pull request
Jan 16, 2026
ClearlyClaire
pushed a commit
that referenced
this pull request
Jan 19, 2026
ClearlyClaire
pushed a commit
that referenced
this pull request
Jan 19, 2026
ClearlyClaire
pushed a commit
that referenced
this pull request
Jan 19, 2026
mistydemeo
pushed a commit
to mistydemeo/mastodon
that referenced
this pull request
Jan 20, 2026
kmycode
pushed a commit
to kmycode/mastodon
that referenced
this pull request
Jan 20, 2026
mimikun
pushed a commit
to mimikun/mastodon
that referenced
this pull request
Jan 23, 2026
mimikun
pushed a commit
to mimikun/mastodon
that referenced
this pull request
Jan 23, 2026
Ember-ruby
pushed a commit
to Ember-ruby/mastodon-glitch
that referenced
this pull request
Jan 24, 2026
mo-rijndael
pushed a commit
to mastodon-ml/mastodon
that referenced
this pull request
Jan 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parse the Vary response header as a comma-separated list instead of splitting on whitespace, so tokens like "Authorization, Accept-Language" correctly match "authorization" and trigger private/no-store when sensitive request headers are present.