Remove trailing variation selector code for legacy emojis#37320
Merged
ClearlyClaire merged 1 commit intomainfrom Dec 19, 2025
Merged
Remove trailing variation selector code for legacy emojis#37320ClearlyClaire merged 1 commit intomainfrom
ClearlyClaire merged 1 commit intomainfrom
Conversation
diondiondion
approved these changes
Dec 19, 2025
ClearlyClaire
approved these changes
Dec 19, 2025
ClearlyClaire
pushed a commit
that referenced
this pull request
Jan 16, 2026
ClearlyClaire
pushed a commit
that referenced
this pull request
Jan 19, 2026
mistydemeo
pushed a commit
to mistydemeo/mastodon
that referenced
this pull request
Jan 20, 2026
mimikun
pushed a commit
to mimikun/mastodon
that referenced
this pull request
Jan 23, 2026
mimikun
pushed a commit
to mimikun/mastodon
that referenced
this pull request
Jan 23, 2026
mo-rijndael
pushed a commit
to mastodon-ml/mastodon
that referenced
this pull request
Jan 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emojibase trims the trailing variation selector code (
U+FE0F) in it's dataset, as emoji like ❤️ often are provided without. This was making those emoji not found in the emoji database.This PR trims trailing variation selector codes to match the Emojibase spec.
Also, if there is a trailing text variation selector code (
U+FE00), instead of trying to look up the emoji the rendering system just exits early to allow for text rendering. For instance, this means characters like❤will render correctly.