Skip to content

Comments

Visibility Modal fixes#35865

Merged
ChaosExAnima merged 4 commits intomainfrom
fix/MAS-542-dropdown-fixes
Aug 22, 2025
Merged

Visibility Modal fixes#35865
ChaosExAnima merged 4 commits intomainfrom
fix/MAS-542-dropdown-fixes

Conversation

@ChaosExAnima
Copy link
Contributor

This PR is a bunch of small changes for the new visibility modal:

  • Fixed reversed tab navigation in dropdowns.
  • Active items in dropdowns have the correct text color in the light theme.
  • Adjacent highlighted dropdown options now do share a border radius.
  • Added save and cancel buttons to the visibility modal to keep it in line with other modals.
Screenshot 2025-08-22 at 12 49 08

@ChaosExAnima ChaosExAnima requested a review from a team August 22, 2025 10:50
@ChaosExAnima ChaosExAnima force-pushed the fix/MAS-542-dropdown-fixes branch from 015df4d to 8b18498 Compare August 22, 2025 11:10
@ChaosExAnima ChaosExAnima force-pushed the fix/MAS-542-dropdown-fixes branch from 8b18498 to ede9b5c Compare August 22, 2025 11:10
@ChaosExAnima ChaosExAnima enabled auto-merge August 22, 2025 11:44
Copy link
Contributor

@diondiondion diondiondion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (though I find the border-radius bit in the menu a bit weird 😅)

@ChaosExAnima ChaosExAnima added this pull request to the merge queue Aug 22, 2025
Merged via the queue into main with commit 4df50b9 Aug 22, 2025
33 checks passed
@ChaosExAnima ChaosExAnima deleted the fix/MAS-542-dropdown-fixes branch August 22, 2025 12:47
@ChaosExAnima
Copy link
Contributor Author

though I find the border-radius bit in the menu a bit weird

me too tbh? but it's a bit of an edge case. i am a bit concerned as well about older browsers that don't support :has() or :is().

@diondiondion
Copy link
Contributor

i am a bit concerned as well about older browsers that don't support :has() or :is().

Luckily they'll just ignore those declarations. I was about to suggest to wrap the first block (that doesn't have the :has() selector) in a @supports query so it's only applied if the second block is, too. But it's such a tiny detail.

ClearlyClaire added a commit to glitch-soc/mastodon that referenced this pull request Aug 24, 2025
* Update dependency vite-plugin-pwa to v1.0.3 (mastodon#35830)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* New Crowdin Translations (automated) (mastodon#35829)

Co-authored-by: GitHub Actions <[email protected]>

* Status quote button (mastodon#35822)

* Use `debug?` query method on httplog initializer check (mastodon#35833)

* Fix display of quotes in threads in WebUI (mastodon#35834)

* Update dependency ruby-vips to v2.2.5 (mastodon#35836)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Disable `Metrics/*` cops (mastodon#35000)

* Update dependency core-js to v3.45.1 (mastodon#35843)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* New Crowdin Translations (automated) (mastodon#35844)

Co-authored-by: GitHub Actions <[email protected]>

* Update dependency vite-plugin-static-copy to v3.1.2 (mastodon#35846)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency rubyzip to v3.0.2 (mastodon#35845)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Composer quote improvements (mastodon#35835)

Co-authored-by: Claire <[email protected]>
Co-authored-by: diondiondion <[email protected]>

* Refactor to reuse the one status partial across moderation tools (mastodon#35644)

* Fix layout shift caused by "Who to follow" widget (mastodon#35861)

* Improvements for keyboard navigation in feeds (mastodon#35853)

* Improve feed item focus outlines (mastodon#35864)

* Visibility Modal fixes (mastodon#35865)

* New Crowdin Translations (automated) (mastodon#35859)

Co-authored-by: GitHub Actions <[email protected]>

* [Glitch] Status quote button

Port 8268323 to glitch-soc

Signed-off-by: Claire <[email protected]>

* [Glitch] Fix display of quotes in threads in WebUI

Port 45ec4c9 to glitch-soc

Signed-off-by: Claire <[email protected]>

* [Glitch] Composer quote improvements

Port f85f0ee to glitch-soc

Co-authored-by: Claire <[email protected]>
Co-authored-by: diondiondion <[email protected]>
Signed-off-by: Claire <[email protected]>

* [Glitch] Refactor to reuse the one status partial across moderation tools

Port 4f49478 to glitch-soc

Signed-off-by: Claire <[email protected]>

* [Glitch] Fix layout shift caused by "Who to follow" widget

Port 511e10d to glitch-soc

Signed-off-by: Claire <[email protected]>

* [Glitch] Improvements for keyboard navigation in feeds

Port 118c30f to glitch-soc

Signed-off-by: Claire <[email protected]>

* [Glitch] Improve feed item focus outlines

Port a1c7b85 to glitch-soc

Signed-off-by: Claire <[email protected]>

* [Glitch] Visibility Modal fixes

Port 4df50b9 to glitch-soc

Signed-off-by: Claire <[email protected]>

---------

Signed-off-by: Claire <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: GitHub Actions <[email protected]>
Co-authored-by: Echo <[email protected]>
Co-authored-by: Matt Jankowski <[email protected]>
Co-authored-by: diondiondion <[email protected]>
Co-authored-by: Emelia Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants