Merged
Conversation
ChaosExAnima
force-pushed
the
feat/quote-post-composer-fixes
branch
2 times, most recently
from
5cce347 to
9ab5ae4
Compare
ChaosExAnima
force-pushed
the
feat/quote-post-composer-fixes
branch
from
9ab5ae4 to
f3c7ed8
Compare
Contributor
|
Apart of design points that are being discussed, there are a few edge cases that are not handled properly:
EDIT: solved |
ClearlyClaire
previously approved these changes
Aug 21, 2025
diondiondion
approved these changes
Aug 21, 2025
app/javascript/mastodon/features/compose/components/visibility_button.tsx
Outdated
Show resolved
Hide resolved
ClearlyClaire
approved these changes
Aug 21, 2025
ClearlyClaire
added a commit
to glitch-soc/mastodon
that referenced
this pull request
Aug 24, 2025
* Update dependency vite-plugin-pwa to v1.0.3 (mastodon#35830) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * New Crowdin Translations (automated) (mastodon#35829) Co-authored-by: GitHub Actions <[email protected]> * Status quote button (mastodon#35822) * Use `debug?` query method on httplog initializer check (mastodon#35833) * Fix display of quotes in threads in WebUI (mastodon#35834) * Update dependency ruby-vips to v2.2.5 (mastodon#35836) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Disable `Metrics/*` cops (mastodon#35000) * Update dependency core-js to v3.45.1 (mastodon#35843) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * New Crowdin Translations (automated) (mastodon#35844) Co-authored-by: GitHub Actions <[email protected]> * Update dependency vite-plugin-static-copy to v3.1.2 (mastodon#35846) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency rubyzip to v3.0.2 (mastodon#35845) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Composer quote improvements (mastodon#35835) Co-authored-by: Claire <[email protected]> Co-authored-by: diondiondion <[email protected]> * Refactor to reuse the one status partial across moderation tools (mastodon#35644) * Fix layout shift caused by "Who to follow" widget (mastodon#35861) * Improvements for keyboard navigation in feeds (mastodon#35853) * Improve feed item focus outlines (mastodon#35864) * Visibility Modal fixes (mastodon#35865) * New Crowdin Translations (automated) (mastodon#35859) Co-authored-by: GitHub Actions <[email protected]> * [Glitch] Status quote button Port 8268323 to glitch-soc Signed-off-by: Claire <[email protected]> * [Glitch] Fix display of quotes in threads in WebUI Port 45ec4c9 to glitch-soc Signed-off-by: Claire <[email protected]> * [Glitch] Composer quote improvements Port f85f0ee to glitch-soc Co-authored-by: Claire <[email protected]> Co-authored-by: diondiondion <[email protected]> Signed-off-by: Claire <[email protected]> * [Glitch] Refactor to reuse the one status partial across moderation tools Port 4f49478 to glitch-soc Signed-off-by: Claire <[email protected]> * [Glitch] Fix layout shift caused by "Who to follow" widget Port 511e10d to glitch-soc Signed-off-by: Claire <[email protected]> * [Glitch] Improvements for keyboard navigation in feeds Port 118c30f to glitch-soc Signed-off-by: Claire <[email protected]> * [Glitch] Improve feed item focus outlines Port a1c7b85 to glitch-soc Signed-off-by: Claire <[email protected]> * [Glitch] Visibility Modal fixes Port 4df50b9 to glitch-soc Signed-off-by: Claire <[email protected]> --------- Signed-off-by: Claire <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <[email protected]> Co-authored-by: Echo <[email protected]> Co-authored-by: Matt Jankowski <[email protected]> Co-authored-by: diondiondion <[email protected]> Co-authored-by: Emelia Smith <[email protected]>
ronilaukkarinen
added a commit
to mementomori-social/mastodon
that referenced
this pull request
Dec 26, 2025
mo-rijndael
pushed a commit
to mastodon-ml/mastodon
that referenced
this pull request
Jan 25, 2026
mo-rijndael
pushed a commit
to mastodon-ml/mastodon
that referenced
this pull request
Jan 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes MAS-538, MAS-528, and MAS-539.
This PR connects the new modal created in #35762 to the composer visibility button. See screenshot below.
In addition, this fixes the following issues:
Notes: