Allow editing status quote policy#35762
Merged
ChaosExAnima merged 11 commits intomainfrom Aug 14, 2025
Merged
Conversation
ChaosExAnima
force-pushed
the
feat/MAS-511-quote-policy
branch
2 times, most recently
from
6e6792d to
d8bf3ed
Compare
ClearlyClaire
requested changes
Aug 13, 2025
ChaosExAnima
force-pushed
the
feat/MAS-511-quote-policy
branch
from
92d6c65 to
9553659
Compare
Contributor
Author
|
converting to draft while the API is being updated. |
ChaosExAnima
force-pushed
the
feat/MAS-511-quote-policy
branch
from
9553659 to
f6e05b5
Compare
ChaosExAnima
force-pushed
the
feat/MAS-511-quote-policy
branch
from
b51b0c5 to
1246d62
Compare
Contributor
ClearlyClaire
left a comment
ClearlyClaire
left a comment
There was a problem hiding this comment.
In the current state of the PR, the dropdown options look like tooltips more than they look like dropdown options.
The privacy/visibility appearing in this place is also confusing, as it cannot be changed after the fact.
The previous issue with the API call resetting some of the post's properties has been fixed.
app/javascript/mastodon/features/ui/components/visibility_modal.tsx
Outdated
Show resolved
Hide resolved
ChaosExAnima
force-pushed
the
feat/MAS-511-quote-policy
branch
from
6bf0fdb to
82d0a7e
Compare
Contributor
ClearlyClaire
left a comment
ClearlyClaire
left a comment
There was a problem hiding this comment.
Haven't dug into the UI code yet but I'm a bit surprised at the redefinition of another dropdown component.
The API call and interface look good to me now.
app/javascript/mastodon/features/ui/components/visibility_modal.tsx
Outdated
Show resolved
Hide resolved
imani-the-maker
left a comment
imani-the-maker
left a comment
There was a problem hiding this comment.
Added one suggestion re: the text in the settings modal once a post is published.
ChaosExAnima
force-pushed
the
feat/MAS-511-quote-policy
branch
from
f56a0d7 to
6d74233
Compare
ClearlyClaire
approved these changes
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the UI to allow for editing a status's quote policy using a modal window. To test you need to enable the
outgoing_quotesexperiment.Note: While the UI exists in the screenshots below, right now the menu item to show this modal is hidden for non-public posts. It will appear for composing new posts however, so I am including those screenshots for completeness.