Skip to content

Comments

Refactor to reuse the one status partial across moderation tools#35644

Merged
ClearlyClaire merged 6 commits intomastodon:mainfrom
ThisIsMissEm:refactor/reuse-status-rendering-partial
Aug 21, 2025
Merged

Refactor to reuse the one status partial across moderation tools#35644
ClearlyClaire merged 6 commits intomastodon:mainfrom
ThisIsMissEm:refactor/reuse-status-rendering-partial

Conversation

@ThisIsMissEm
Copy link
Contributor

@ThisIsMissEm ThisIsMissEm commented Aug 3, 2025

This is a continuation of #30813 — previously we had multiple different "render a status" pieces of code, when there wasn't too much variation between each.

This allows us to more easily improve rendering of the statuses across the moderation tools such that they appear consistently in each case. The new shared partials will be reused by appeals and report action previews in future PRs.

I'll also be doing follow up PRs to add rendering of polls and link previews within statuses in the moderation tools.

@ThisIsMissEm ThisIsMissEm force-pushed the refactor/reuse-status-rendering-partial branch from 9e49ddc to 6782cac Compare August 3, 2025 18:01
@ThisIsMissEm ThisIsMissEm force-pushed the refactor/reuse-status-rendering-partial branch from 6782cac to 2ea43ab Compare August 9, 2025 16:12
@mjankowski mjankowski added ui Front-end, design refactoring Improving code quality ruby Pull requests that update Ruby code labels Aug 12, 2025
@ThisIsMissEm ThisIsMissEm force-pushed the refactor/reuse-status-rendering-partial branch from acf18a0 to e36625c Compare August 14, 2025 18:30
@ThisIsMissEm
Copy link
Contributor Author

@ClearlyClaire have removed the changes to status edit around visibility.
Screenshot 2025-08-14 at 20 31 15

The dates are duplicated there, but without them it looks a little.. weird, because we're so used to seeing information below the status content.

Copy link
Contributor

@ClearlyClaire ClearlyClaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review, this PR somehow slipped through the cracks again.

Thank you for your contributions, it's looking good to me now!

@ClearlyClaire ClearlyClaire added this pull request to the merge queue Aug 21, 2025
@ClearlyClaire ClearlyClaire added the to backport PR needed to be backported label Aug 21, 2025
Merged via the queue into mastodon:main with commit 4f49478 Aug 21, 2025
36 checks passed
ClearlyClaire added a commit to glitch-soc/mastodon that referenced this pull request Aug 24, 2025
* Update dependency vite-plugin-pwa to v1.0.3 (mastodon#35830)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* New Crowdin Translations (automated) (mastodon#35829)

Co-authored-by: GitHub Actions <[email protected]>

* Status quote button (mastodon#35822)

* Use `debug?` query method on httplog initializer check (mastodon#35833)

* Fix display of quotes in threads in WebUI (mastodon#35834)

* Update dependency ruby-vips to v2.2.5 (mastodon#35836)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Disable `Metrics/*` cops (mastodon#35000)

* Update dependency core-js to v3.45.1 (mastodon#35843)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* New Crowdin Translations (automated) (mastodon#35844)

Co-authored-by: GitHub Actions <[email protected]>

* Update dependency vite-plugin-static-copy to v3.1.2 (mastodon#35846)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency rubyzip to v3.0.2 (mastodon#35845)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Composer quote improvements (mastodon#35835)

Co-authored-by: Claire <[email protected]>
Co-authored-by: diondiondion <[email protected]>

* Refactor to reuse the one status partial across moderation tools (mastodon#35644)

* Fix layout shift caused by "Who to follow" widget (mastodon#35861)

* Improvements for keyboard navigation in feeds (mastodon#35853)

* Improve feed item focus outlines (mastodon#35864)

* Visibility Modal fixes (mastodon#35865)

* New Crowdin Translations (automated) (mastodon#35859)

Co-authored-by: GitHub Actions <[email protected]>

* [Glitch] Status quote button

Port 8268323 to glitch-soc

Signed-off-by: Claire <[email protected]>

* [Glitch] Fix display of quotes in threads in WebUI

Port 45ec4c9 to glitch-soc

Signed-off-by: Claire <[email protected]>

* [Glitch] Composer quote improvements

Port f85f0ee to glitch-soc

Co-authored-by: Claire <[email protected]>
Co-authored-by: diondiondion <[email protected]>
Signed-off-by: Claire <[email protected]>

* [Glitch] Refactor to reuse the one status partial across moderation tools

Port 4f49478 to glitch-soc

Signed-off-by: Claire <[email protected]>

* [Glitch] Fix layout shift caused by "Who to follow" widget

Port 511e10d to glitch-soc

Signed-off-by: Claire <[email protected]>

* [Glitch] Improvements for keyboard navigation in feeds

Port 118c30f to glitch-soc

Signed-off-by: Claire <[email protected]>

* [Glitch] Improve feed item focus outlines

Port a1c7b85 to glitch-soc

Signed-off-by: Claire <[email protected]>

* [Glitch] Visibility Modal fixes

Port 4df50b9 to glitch-soc

Signed-off-by: Claire <[email protected]>

---------

Signed-off-by: Claire <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: GitHub Actions <[email protected]>
Co-authored-by: Echo <[email protected]>
Co-authored-by: Matt Jankowski <[email protected]>
Co-authored-by: diondiondion <[email protected]>
Co-authored-by: Emelia Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactoring Improving code quality ruby Pull requests that update Ruby code ui Front-end, design

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants