Add preview card to public statuses#2268
Conversation
mikoim
force-pushed
the
feature-preview-card-on-status
branch
from
299f1ec to
b2613ad
Compare
|
Could somebody review this PR? |
There was a problem hiding this comment.
This must be a way lighter color. $color3 maybe?
mikoim
force-pushed
the
feature-preview-card-on-status
branch
from
b2613ad to
3118d45
Compare
|
@Gargron thank you, I changed the color. |
mikoim
force-pushed
the
feature-preview-card-on-status
branch
2 times, most recently
from
1f2b7cf to
2d5c73b
Compare
|
I rebased this branch to fix conflicts. Please review again. |
app/helpers/routing_helper.rb
Outdated
There was a problem hiding this comment.
If you like Addressable::URI.parse(url).display_uri.hostname you can correspond to IDNA.
There was a problem hiding this comment.
change to %p.status-card__description
There was a problem hiding this comment.
change to %strong.status-card__title{ title: card.title }
There was a problem hiding this comment.
change to %span.status-card__host{ style: 'display: block; margin-top: 5px; font-size: 13px' }
There was a problem hiding this comment.
Why use the style attribute instead of the stylesheet?
There was a problem hiding this comment.
change to render 'stream_entries/preview_card', card: card
mikoim
force-pushed
the
feature-preview-card-on-status
branch
from
2d5c73b to
0879607
Compare
|
@ykzts thank you for your review. I fixed problems. |
mikoim
force-pushed
the
feature-preview-card-on-status
branch
from
0879607 to
76316d9
Compare
|
rebased |
|
will this be merged? |
5 participants
This PR makes preview card displayable in public statuses. It needs to brush up design because I just copied a style from React implement.
demo