Repository navigation
Commit fcab4f2
committed
[X-2935] PhysicalExtensionCodec: thread proto_converter through methods
Modifies the PhysicalExtensionCodec trait so that try_encode, try_decode,
try_encode_expr, and try_decode_expr receive the active
PhysicalProtoConverterExtension. Codecs that embed nested PhysicalExprNode
fields inside their custom proto (e.g. atlas's ReverseParquetNode.predicate)
must now route those through proto_converter.proto_to_physical_expr /
proto_converter.physical_expr_to_proto so the dedup cache extends across
the extension boundary.
Without this plumbing, an outer DeduplicatingSerializer can't reach
into extension nodes -- the dedup cache stops at the extension boundary
and Arc<Inner> sharing breaks for any expression carried inside an
extension codec, even though the wire format already supports it via
the expr_id field. With this change, atlas can finally drop the
share_dynamic_filters walker once its codecs override the new methods.
This is the breaking-change pattern matching the apache/datafusion
upstream design (issue apache#22920) instead of additive _with_converter
variants -- branch-53 is internal-only so callers can be updated in
lockstep.1 parent 0e6d988 commit fcab4f2
3 files changed
Lines changed: 69 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
506 | 506 | | |
507 | 507 | | |
508 | 508 | | |
509 | | - | |
| 509 | + | |
| 510 | + | |
| 511 | + | |
| 512 | + | |
| 513 | + | |
| 514 | + | |
| 515 | + | |
| 516 | + | |
| 517 | + | |
510 | 518 | | |
511 | 519 | | |
512 | 520 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
572 | 572 | | |
573 | 573 | | |
574 | 574 | | |
575 | | - | |
| 575 | + | |
| 576 | + | |
| 577 | + | |
| 578 | + | |
| 579 | + | |
576 | 580 | | |
577 | 581 | | |
578 | 582 | | |
| |||
1787 | 1791 | | |
1788 | 1792 | | |
1789 | 1793 | | |
1790 | | - | |
| 1794 | + | |
| 1795 | + | |
| 1796 | + | |
| 1797 | + | |
| 1798 | + | |
| 1799 | + | |
1791 | 1800 | | |
1792 | 1801 | | |
1793 | 1802 | | |
| |||
3717 | 3726 | | |
3718 | 3727 | | |
3719 | 3728 | | |
| 3729 | + | |
| 3730 | + | |
| 3731 | + | |
| 3732 | + | |
| 3733 | + | |
| 3734 | + | |
| 3735 | + | |
| 3736 | + | |
| 3737 | + | |
| 3738 | + | |
3720 | 3739 | | |
3721 | 3740 | | |
3722 | 3741 | | |
3723 | 3742 | | |
3724 | 3743 | | |
| 3744 | + | |
3725 | 3745 | | |
3726 | 3746 | | |
3727 | | - | |
| 3747 | + | |
| 3748 | + | |
| 3749 | + | |
| 3750 | + | |
| 3751 | + | |
| 3752 | + | |
| 3753 | + | |
| 3754 | + | |
| 3755 | + | |
3728 | 3756 | | |
3729 | 3757 | | |
3730 | 3758 | | |
| |||
3734 | 3762 | | |
3735 | 3763 | | |
3736 | 3764 | | |
| 3765 | + | |
| 3766 | + | |
| 3767 | + | |
3737 | 3768 | | |
3738 | 3769 | | |
3739 | 3770 | | |
3740 | 3771 | | |
| 3772 | + | |
3741 | 3773 | | |
3742 | 3774 | | |
3743 | 3775 | | |
3744 | 3776 | | |
| 3777 | + | |
| 3778 | + | |
| 3779 | + | |
3745 | 3780 | | |
3746 | 3781 | | |
3747 | 3782 | | |
3748 | 3783 | | |
| 3784 | + | |
3749 | 3785 | | |
3750 | 3786 | | |
3751 | 3787 | | |
| |||
3778 | 3814 | | |
3779 | 3815 | | |
3780 | 3816 | | |
| 3817 | + | |
3781 | 3818 | | |
3782 | 3819 | | |
3783 | 3820 | | |
| |||
3786 | 3823 | | |
3787 | 3824 | | |
3788 | 3825 | | |
| 3826 | + | |
3789 | 3827 | | |
3790 | 3828 | | |
3791 | 3829 | | |
| |||
4213 | 4251 | | |
4214 | 4252 | | |
4215 | 4253 | | |
| 4254 | + | |
4216 | 4255 | | |
4217 | | - | |
| 4256 | + | |
| 4257 | + | |
| 4258 | + | |
4218 | 4259 | | |
4219 | 4260 | | |
4220 | | - | |
4221 | | - | |
| 4261 | + | |
| 4262 | + | |
| 4263 | + | |
| 4264 | + | |
| 4265 | + | |
| 4266 | + | |
| 4267 | + | |
| 4268 | + | |
| 4269 | + | |
4222 | 4270 | | |
4223 | 4271 | | |
4224 | 4272 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
576 | 576 | | |
577 | 577 | | |
578 | 578 | | |
579 | | - | |
| 579 | + | |
| 580 | + | |
| 581 | + | |
| 582 | + | |
| 583 | + | |
| 584 | + | |
580 | 585 | | |
581 | 586 | | |
582 | 587 | | |
| |||
0 commit comments