You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 1ea3955
Browse filesBrowse the repository at this point in the historyBrowse files
[X-2935] PhysicalExtensionCodec: thread proto_converter through methods
Modifies the PhysicalExtensionCodec trait so that try_encode, try_decode,
try_encode_expr, and try_decode_expr receive the active
PhysicalProtoConverterExtension. Codecs that embed nested PhysicalExprNode
fields inside their custom proto (e.g. atlas's ReverseParquetNode.predicate)
must now route those through proto_converter.proto_to_physical_expr /
proto_converter.physical_expr_to_proto so the dedup cache extends across
the extension boundary.
Without this plumbing, an outer DeduplicatingSerializer can't reach
into extension nodes -- the dedup cache stops at the extension boundary
and Arc<Inner> sharing breaks for any expression carried inside an
extension codec, even though the wire format already supports it via
the expr_id field. With this change, atlas can finally drop the
share_dynamic_filters walker once its codecs override the new methods.
This is the breaking-change pattern matching the apache/datafusion
upstream design (issue apache#22920) instead of additive _with_converter
variants -- branch-53 is internal-only so callers can be updated in
lockstep.
0 commit comments