Path #156
Path #156
Conversation
…s to access a node via path object.
… operator, copy and move, and comparison operators
… truncate, truncated, leaf, various operators, and string casts
…e warnings, fixed which resulted in more readable truncate() code also.
marzer
left a comment
marzer
left a comment
There was a problem hiding this comment.
Great work man! I am looking forward to releasing this feature. A few nits, but I've tried not to be too picky.
…r truncate, truncated, and leaf
…ing of some methods
…tor[] path access
|
Updates! |
marzer
left a comment
marzer
left a comment
There was a problem hiding this comment.
Home stretch, methinks. Mostly just pedantic library/structural nits :)
|
Fixes pushed! |
|
Yup, looks good to me @jonestristand! There's a few bits-and-pieces I'll want to do post-merge so I won't merge it in until I have time to do that (this weekend mayyyybe, otherwise some weekend soon), so if there's more you think you want to add (any other utility functions etc.) feel free to push to this branch before then :) |
|
Going to look after this tomorrow or Sunday this weekend FYI @jonestristand |
|
Awesome, pumped to have it merged in! I'm just adding a subpath method today so luckily that'll sneak in under the wire ;-) |
|
Thanks @jonestristand! I'll keep it in the |
2 participants
What does this change do?
This PR adds an implementation of toml::path which represents a path to an arbitrary toml node. It provides utilities for path manipulation by path segment (e.g. parents, truncation), as well as comparisons between paths. toml::path objects may be used as an argument for at_path.
Is it related to an exisiting bug report or feature request?
Fixes #153.
Pre-merge checklist
origin/master(if necessary)