clang 10.0: error: unknown warning group '-Wsuggest-destructor-override' #145 #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hi, thanks for the contribution! Looks good to me, but before I can merge you'll need to also regenerate the single-header version of the library (see CONTRIBUTING.md for info). |
marzer
requested changes
Mar 14, 2022
Contributor
Author
|
Single header toml.hpp generated and provided! |
Contributor
Author
|
Also I can confirm that now toml++ module compiles fine on all latest major platforms in github-actions: |
Contributor
Author
|
Also provided a fix for MinGW platform |
marzer
reviewed
Mar 14, 2022
Contributor
Author
|
MinGW compiles fine as well |
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
origin/master(if necessary)