-
-
Notifications
You must be signed in to change notification settings - Fork 185
Closed
Labels
bugSomething isn't workingSomething isn't workingimplemented in v3Fixes + features which were implemented in v3 release.Fixes + features which were implemented in v3 release.
Description
Environment
toml++ version and/or commit hash: 2.5.0
Compiler: gcc 7.3.1 (but I believe all versions including the latest as of writing, 11.2)
C++ standard mode: 17
Target arch: x64
Library configuration overrides: TOML_EXCEPTIONS is 1
Relevant compilation flags: None
Describe the bug
There's a gcc bug that causes a memory leak when an exception is thrown by parse_value() here, specifically because the destructor of the moved-to key is not called.
It looks like you've done a significant refactor for toml++ v3, so feel free to withdraw this if it's no longer an issue going forward.
Additional information
We found this using AddressSanitizer. Does it make sense to incorporate this tool into your tests and CI?
Nice library! Looking forward to v3. 😃👍
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingimplemented in v3Fixes + features which were implemented in v3 release.Fixes + features which were implemented in v3 release.