Skip to content

Mdurant v3 fsspec#23

Merged
martindurant merged 7 commits into
martindurant:v3_fsspecfrom
d-v-b:mdurant_v3_fsspec
Jun 10, 2024
Merged

Mdurant v3 fsspec#23
martindurant merged 7 commits into
martindurant:v3_fsspecfrom
d-v-b:mdurant_v3_fsspec

Conversation

@d-v-b

@d-v-b d-v-b commented Jun 9, 2024 •
edited
Loading

Copy link
Copy Markdown

Adds an instance of StoreTests parametrized by RemoteStore, and refactors the store tests layout

Not mergeable until we figure out why the tests are failing

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

martindurant
martindurant reviewed Jun 10, 2024
View reviewed changes
Comment thread tests/v3/test_store/test_remote.py Outdated
Comment thread tests/v3/test_store/test_remote.py Outdated
Comment thread tests/v3/test_store/test_remote.py Outdated
@d-v-b

d-v-b commented Jun 10, 2024

Copy link
Copy Markdown
Author

@martindurant can you approve the workflows so we can see some test failures? that's the part I need help with :)

@martindurant

martindurant commented Jun 10, 2024

Copy link
Copy Markdown
Owner

I see no test failures :)

@martindurant
martindurant merged commit 7c22f74 into martindurant:v3_fsspec Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martindurant martindurant martindurant left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@d-v-b @martindurant