Drop claim that CPython 3.6+ preserves Marshmallow schema order#229
Merged
lafrech merged 1 commit intomarshmallow-code:masterfrom Feb 11, 2021
Merged
Drop claim that CPython 3.6+ preserves Marshmallow schema order#229lafrech merged 1 commit intomarshmallow-code:masterfrom
lafrech merged 1 commit intomarshmallow-code:masterfrom
Conversation
Unfortunately, the actual Marshmallow `Schema` implementation that orders fields uses _sets_ and so doesn't honour schema field order. Fixes marshmallow-code#228
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately, the actual Marshmallow
Schemaimplementation that orders fields uses sets and so doesn't honour schema field order.Fixes #228