Fix timeout error in conversion with Chrome 139 #683
Merged
+24
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tent()` into following `page.waitForNetworkIdle()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #682.
Marp CLI has used
{ waitUntil: ['domcontentloaded', 'networkidle0'] }in Puppeteer operations for a long time. However, the latest Chrome 139 seems not to work that inpage.setContent().This PR splits
networkidle0option into a separated operationawait page.waitForNetworkIdle()to mitigate the timeout error.Tip
page.setContent()function is not used when using--allow-local-filesoption.