Avoid using dynamic import() in the bundled output as much as possible
#677
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #676.
The latest pptxgenjs has improved support for hybrid environments, such as Web, Node.js, and other bundlers. If pptxgenjs detected running on Node.js, pptxgenjs will try to import
node:fsandnode:httpsdynamically withimportstatement.However, a dyanamic
importstatement is known that it does not work as expected in the binary build packaged bypkg(@yao-pkg/pkg).So I've updated the configuration of rollup
output.dynamicImportInCjstofalse, to apply downlevel transpiling for dynamicimport()to userequire().This transpilation will break already ESM compatible import for the engine so I also have added the rollup plugin for keeping dynamic
import()for the engine.