Skip to content

Upgrade Node.js and dependent packages #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yhatt merged 7 commits into from
Feb 18, 2025
Merged

Upgrade Node.js and dependent packages #648

yhatt merged 7 commits into from
Feb 18, 2025

Conversation

@yhatt
Copy link
Member

@yhatt yhatt commented Feb 17, 2025

Notable changes

  • Node.js LTS has been bumped to v22.14.0

@codecov
Copy link

codecov bot commented Feb 17, 2025 •
edited
Loading

❌ 6 Tests Failed:

Tests completed Failed Passed Skipped
390 6 384 1
View the top 3 failed test(s) by shortest run time 
WatchNotifier #sendTo sends command to listening sockets and returns true
Stack Traces | 0.006s run time 
TypeError: ws_1.WebSocketServer is not a constructor
    at WatchNotifier.start (D:\a\marp-cli\marp-cli\src\watcher.ts:116:16)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at Object.<anonymous> (D:\a\marp-cli\marp-cli\test\watcher.ts:226:7)
WatchNotifier #start when client is connected to registered path adds socket to registered set and sends "ready" command
Stack Traces | 0.006s run time 
TypeError: ws_1.WebSocketServer is not a constructor
    at WatchNotifier.start (D:\a\marp-cli\marp-cli\src\watcher.ts:116:16)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at Object.<anonymous> (D:\a\marp-cli\marp-cli\test\watcher.ts:275:9)
WatchNotifier #start when client is connected to registered path closes client socket immediately when passed invalid URL
Stack Traces | 0.006s run time 
TypeError: ws_1.WebSocketServer is not a constructor
    at WatchNotifier.start (D:\a\marp-cli\marp-cli\src\watcher.ts:116:16)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at Object.<anonymous> (D:\a\marp-cli\marp-cli\test\watcher.ts:299:9)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

yhatt
yhatt commented Feb 18, 2025
View reviewed changes
package.json
"globals": "^15.14.0",
"globby": "^14.0.2",
"globals": "^15.15.0",
"globby": "~14.0.2",
Copy link
Member Author

@yhatt yhatt Feb 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating globby to v14.1.0 prevents tests from running due to dependency issues, as described in sindresorhus/globby#260. As a long-term solution, replacing it with tinyglobby could be considered. However, for now, we will address the issue by pinning the version to the specific minor.

@yhatt yhatt merged commit 9f4e15e into main Feb 18, 2025
1 check passed
@yhatt yhatt deleted the upgrade-dependencies branch February 18, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yhatt