Skip to content

Added missing EditView.getUrl parameter#990

Merged
fzaninotto merged 1 commit intomarmelab:masterfrom
SebLours:master
Mar 31, 2016
Merged

Added missing EditView.getUrl parameter#990
fzaninotto merged 1 commit intomarmelab:masterfrom
SebLours:master

Conversation

@SebLours
Copy link
Copy Markdown
Contributor

Patch for #871 (EditView, not ListView)

@fzaninotto
Copy link
Copy Markdown
Member

Could you remove the built files from your PR? They make it hard to merge. I'll rebuild the files myself once merged.

@SebLours
Copy link
Copy Markdown
Contributor Author

⏪ It's done

@SebLours
Copy link
Copy Markdown
Contributor Author

I ask my self if this PR is ready ...

For example a route like this (entity with a composite keys id): /#/crew_members/edit/2501,1947
The id will be passed as string ('2501,1947') at EditView.getUrl, i think that in this case, the id argument must be an array [2501,1947]

I don't know how to get the id as array from $state.params ...

@fzaninotto fzaninotto merged commit 97c64ce into marmelab:master Mar 31, 2016
@fzaninotto
Copy link
Copy Markdown
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants