#372 allow sortable(false) on fields in list view by RichardBradley · Pull Request #984 · marmelab/ng-admin

RichardBradley · 2016-03-17T10:15:30Z

Fixes #372

(UPDATE: please ignore the rest of this comment, it refers to an old version of this PR. Jump straight to the comment starting "OK, I have updated this pull request to include the necessary changes")

As discussed on that thread, this PR is much easier if I don't have to also modify admin-config.
However, it does look rather out of place next to all the fields with function getters & setters, so maybe a version which spans the two respositories would be better.

This version works for me though.

(Another benefit of the getter/setter approach is that it allows a "builder" style. This version is awkward to use:

articles.listView()
   .fields(
       nga.field('id'),
       function() {
            var headline = nga.field('headline');
            // Headline is an "analyzed" string field, so cannot be sorted in ES
            // https://www.elastic.co/guide/en/elasticsearch/guide/current/multi-fields.html
            headline.disableSort = true;
            return headline;
        }(),
        nga.field('publication_time', 'datetime'),
        nga.field('type')
    ])

whereas the getter/setter version would look like

articles.listView()
   .fields(
       nga.field('id'),
       nga.field('headline')
            // Headline is an "analyzed" string field, so cannot be sorted in ES
            // https://www.elastic.co/guide/en/elasticsearch/guide/current/multi-fields.html
            .disableSort(true),
        nga.field('publication_time', 'datetime'),
        nga.field('type')
    ])

)

RichardBradley · 2016-03-17T10:16:46Z

Taking a step back, why is admin-config in a separate git repos to ng-admin?
It would simplify the project a lot to merge them together; they are already very tightly coupled, so having them in separate repositories just adds administrative overhead.

fzaninotto · 2016-03-18T20:40:48Z

admin-config is also used by react-admin, that's why it's independent.

Please update admin-config with a related PR to use a more usual function syntax.

Fr4ncx · 2016-03-22T12:35:34Z

.disableSort(true), Not work in my panel, why?

RichardBradley · 2016-03-27T12:13:10Z

.disableSort(true), Not work in my panel, why?

Because this enhancement has not yet been implemented.
The issue is still marked "open" at the top -- subscribe to #372 for updates and try again when it is marked "closed".

RichardBradley · 2016-04-03T08:45:48Z

Please update admin-config with a related PR to use a more usual function syntax.

@fzaninotto Is there a guide on how best to do this?

I'll make the changes to admin-config; do I then need to bump its version and update the dependency reference in ng-admin/package.json? How will that work if the PR to admin-config has not been merged / published yet?

I suppose I should publish it locally somehow (how?) and then have my local ng-admin depend on my locally modified admin-config. Then I'll be pushing a version of ng-admin which will work only for me (until the PR in admin-config is merged), which seems messy.

RichardBradley · 2016-04-04T10:32:52Z

OK, I have updated this pull request to include the necessary changes to admin-config. Please could you take another look and merge if you are happy?

This now depends on marmelab/admin-config#65 -- please merge and release that first, or this will fail.

I have bumped the admin-config version and increased the version required by ng-admin accordingly.

I have not included changes to build/, as requested in the README

RichardBradley · 2016-04-04T10:35:10Z

(The CI build has failed because it cannot find the not-yet-published version of admin-config on which this change depends. This is inevitable with the current git repos structure, as briefly discussed above.)

RichardBradley · 2016-04-04T10:56:49Z

I have changed the syntax from the proposed "disabledSort(true)" to ".sortable(false)", as it better matches the other Field properties like "editable"

fzaninotto · 2016-05-25T14:42:15Z

doc/reference/Field.md

@@ -5,21 +5,21 @@ A field is the representation of a property of an entity.
 * [General Field Settings](#general-field-settings)


please revert these changes, they are not related to this PR, and break the ng-admin book on GitBook (i.e. the official doc)

OK, will do.

The links are currently broken on GitHub, see e.g. https://github.com/marmelab/ng-admin/blob/master/doc/reference/Field.md#-date-field-type

They do work on the "GitBook" version, you're right: http://ng-admin-book.marmelab.com/doc/reference/Field.html#-date-field-type

It's a shame that the two differ. I hadn't spotted the "GitBook" version; I'd been referring to the documentation on GItHub directly up until now. If the GitBook version is the official one, it should win, of course.

RichardBradley · 2016-06-15T12:50:49Z

I have pushed a new version with the requested changes (and rebased to account for other changes in the meantime).

fzaninotto · 2016-12-01T10:32:55Z

This PR is OK, just needs rebasing

fzaninotto · 2016-12-01T10:37:31Z

Superseded by #1260

RichardBradley force-pushed the 372_disable_sort branch from 9f41a08 to 8c2215e Compare April 4, 2016 10:29

RichardBradley changed the title ~~#372 allow disableSort on fields in list view~~ #372 allow sortable(false) on fields in list view Apr 4, 2016

RichardBradley mentioned this pull request Apr 4, 2016

Add Field.sortable property for ng-admin/#372 marmelab/admin-config#65

Merged

fzaninotto reviewed May 25, 2016
View reviewed changes

marmelab#372 allow sortable(false) on fields in list view

b095fe6

RichardBradley force-pushed the 372_disable_sort branch from 8c2215e to b095fe6 Compare June 15, 2016 12:50

RichardBradley mentioned this pull request Jul 6, 2016

Remove Column from sorting #372

Closed

fzaninotto added this to the 1.0 milestone Nov 18, 2016

fzaninotto mentioned this pull request Dec 1, 2016

[RFR] Allow to disable sort on columns #1260

Merged

fzaninotto closed this Dec 1, 2016

		@@ -5,21 +5,21 @@ A field is the representation of a property of an entity.
		* [General Field Settings](#general-field-settings)

Conversation

RichardBradley commented Mar 17, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RichardBradley commented Mar 17, 2016

Uh oh!

fzaninotto commented Mar 18, 2016

Uh oh!

Fr4ncx commented Mar 22, 2016

Uh oh!

RichardBradley commented Mar 27, 2016

Uh oh!

RichardBradley commented Apr 3, 2016

Uh oh!

RichardBradley commented Apr 4, 2016

Uh oh!

RichardBradley commented Apr 4, 2016

Uh oh!

RichardBradley commented Apr 4, 2016

Uh oh!

fzaninotto May 25, 2016

Choose a reason for hiding this comment

Uh oh!

RichardBradley May 25, 2016

Choose a reason for hiding this comment

Uh oh!

RichardBradley commented Jun 15, 2016

Uh oh!

fzaninotto commented Dec 1, 2016

Uh oh!

fzaninotto commented Dec 1, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

RichardBradley commented Mar 17, 2016 •

edited

Loading