Skip to content

Fix date field write widget#573

Closed
manuelnaranjo wants to merge 1 commit intomarmelab:masterfrom
manuelnaranjo:date-field
Closed

Fix date field write widget#573
manuelnaranjo wants to merge 1 commit intomarmelab:masterfrom
manuelnaranjo:date-field

Conversation

@manuelnaranjo
Copy link
Copy Markdown

Date field write widget was inside a wrong container, making it display ugly

Date field write widget was inside a wrong container, making it display ugly
@fzaninotto
Copy link
Copy Markdown
Member

What? No, limiting the date widget width was done on purpose, and it works fine. See the example from the demo:

image

Can you show us the visual difference between before and after your PR?

@manuelnaranjo
Copy link
Copy Markdown
Author

I had an example, if I reproduce it again I post it here, want to close this until then?

I've been thinking that row, label and field classes should be configurable, I've been thinking on how to implement this, when I make a demo I open an issue.

@fzaninotto fzaninotto closed this Aug 4, 2015
@manuelnaranjo
Copy link
Copy Markdown
Author

Found it!

ng-admin-dates

I can give you guys access to our server so you can look at it by your selfs if anyone is willing to look at it. Just look for me at gitter.

@fzaninotto
Copy link
Copy Markdown
Member

Did you customize the CSS?

@fzaninotto fzaninotto reopened this Sep 1, 2015
@manuelnaranjo
Copy link
Copy Markdown
Author

@fzaninotto nope, the date field is set to col-sm-4 by default which is too short for displaying this dates.

fzaninotto added a commit that referenced this pull request Sep 7, 2015
@fzaninotto
Copy link
Copy Markdown
Member

Superseded by #673

@fzaninotto fzaninotto closed this Sep 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants