[RFR] Delete button state-params fix#537
Closed
vasiakorobkin wants to merge 2 commits intomarmelab:masterfrom
Closed
[RFR] Delete button state-params fix#537vasiakorobkin wants to merge 2 commits intomarmelab:masterfrom
vasiakorobkin wants to merge 2 commits intomarmelab:masterfrom
Conversation
Contributor
|
Good to me. Can you just add a test to prove the bug fix? :) |
Member
|
No idea why the protractor build failed, I just restarted it. |
Author
|
Wrote end-to-end test to prove the bug fix. |
Contributor
|
Needs rebase |
jpetitcolas
changed the title
Contributor
|
Can you prefix all your PR ready for review or merge by |
Member
|
still needs rebase... |
Author
|
Rebased branch and |
vasiakorobkin
force-pushed
the
delete_button_fix
branch
2 times, most recently
from
4466a38 to
c5331a2
Compare
Contributor
|
A last rebase to get a green tick from Travis? :) |
vasiakorobkin
force-pushed
the
delete_button_fix
branch
from
c5331a2 to
2bebac5
Compare
Author
|
Rebased. All test has been passed successfully. |
Contributor
|
I merged another of your PR. Can you rebase a last time? :) |
vasiakorobkin
force-pushed
the
delete_button_fix
branch
from
2bebac5 to
fa78af6
Compare
Author
|
Done. |
Contributor
|
Superseeded by #642. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #535