Skip to content

[RFR] Fix BC issue with step attribute#494

Merged
manuquentin merged 1 commit intomasterfrom
bc_step_issue
Jun 8, 2015
Merged

[RFR] Fix BC issue with step attribute#494
manuquentin merged 1 commit intomasterfrom
bc_step_issue

Conversation

@jpetitcolas
Copy link
Copy Markdown
Contributor

Adding float type introduced a backward compatibility issue. As new ma-input directive now has a ng-attr-step attribute, it skipped the step attribute set through the Field.attributes() method.

This PR fixes it, allowing the following code:

nga.filter('count', 'number').attributes({ step: 'any' }).format('0.000');

To be equivalent to:

nga.filter('count', 'float');

manuquentin added a commit that referenced this pull request Jun 8, 2015
[RFR] Fix BC issue with step attribute
@manuquentin manuquentin merged commit 392cf36 into master Jun 8, 2015
@manuquentin manuquentin deleted the bc_step_issue branch June 8, 2015 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants