added custom HTTP-Methods for create and update#451
Closed
matsluni wants to merge 2 commits intomarmelab:masterfrom
Closed
added custom HTTP-Methods for create and update#451matsluni wants to merge 2 commits intomarmelab:masterfrom
matsluni wants to merge 2 commits intomarmelab:masterfrom
Conversation
Member
There was a problem hiding this comment.
The variable name isn't well chosen. Use resource instead. Same in UpdateQueries
Contributor
Author
|
Ok, I changed the variable name to resource. Is there anything more I can do? |
Contributor
|
Can you rebase please ? |
Contributor
Author
|
I tried to rebase and saw that you moved some pieces around! ;-) I have look closer to rebase correctly. |
Contributor
|
You will need to do all this modifications on the new https://github.com/marmelab/admin-config repository. Sorry for inconvenience. |
This was referenced Jun 3, 2015
fzaninotto
added a commit
that referenced
this pull request
Jul 13, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
for a current task I need the possibility to set a custom HTTP method for a create operation, in my case 'put' instead of 'post'. I saw a similar request in #362.
I gave it a try in this pull request. The change I did works for me, so please consider merging if you think this is a useful addition.
If you think another approach for the same goal is better just get back to me.
I also tried to add tests for this in CreateQueriesSpec.js and UpdateQueriesSpec.js but couldn't figure out to set the xxxMethod on the entity. So, if you could give me a hint I will add this as well.
Kind regards,
Matthias