Skip to content

[RFR] Update filters on view initialization#1366

Merged
Kmaschta merged 1 commit intomasterfrom
fix-pinned-filter-initialization
Sep 29, 2017
Merged

[RFR] Update filters on view initialization#1366
Kmaschta merged 1 commit intomasterfrom
fix-pinned-filter-initialization

Conversation

@floo51
Copy link
Copy Markdown
Contributor

@floo51 floo51 commented Sep 29, 2017

Fixes an issue where a pinned filter wouldn't filter with its initially selected value.

@Kmaschta
Copy link
Copy Markdown
Contributor

Does this PR fix this issue ? #1204

@floo51
Copy link
Copy Markdown
Contributor Author

floo51 commented Sep 29, 2017

No, I don't think defaultValue actually applies for filters.
We can still implement something like it with map and transform returning our default value where no value is given in the map function by instance.

@Kmaschta Kmaschta merged commit eb8b125 into master Sep 29, 2017
@Kmaschta Kmaschta deleted the fix-pinned-filter-initialization branch September 29, 2017 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants