[RFR] Use http error service handlers inside view events#1339
Merged
fzaninotto merged 2 commits intomasterfrom Apr 27, 2017
Merged
[RFR] Use http error service handlers inside view events#1339fzaninotto merged 2 commits intomasterfrom
fzaninotto merged 2 commits intomasterfrom
Conversation
Contributor
|
I'm OK with this PR. |
floo51
force-pushed
the
fix_httperrorservice_decorator
branch
from
39b4ce9 to
1336e2d
Compare
floo51
changed the title
Kmaschta
approved these changes
Apr 26, 2017
Contributor
Kmaschta
left a comment
Kmaschta
left a comment
There was a problem hiding this comment.
To be tested on a real project.
Contributor
Author
|
Just tested, works as expected |
Phocea
approved these changes
Apr 27, 2017
Contributor
Phocea
left a comment
Phocea
left a comment
There was a problem hiding this comment.
Sorry for the delay, was attending a workshop!
This unify the code very well, good catch.
fzaninotto
approved these changes
Apr 27, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
HttpErrorServicedecorator wasn't working on view like on "Submit changes".It should now work.
Still untested, need some more work.