Merged
Conversation
Contributor
Author
|
@Kmaschta .. Rebasing done the trick. So this is the way to go until we figure out the problem with the tests.... |
Contributor
|
Hmmm.. Does it work with If it's the case, we won't need the _postinstall script. |
Contributor
Author
|
Nope, see 9a845e4#commitcomment-20044668 |
Contributor
|
There is still an issue with the postinstall, can you figure out why?
|
Contributor
Author
|
Looks more like a protractor issue you are getting there. I restarted Travis build and its fine in their VM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on E2E fix commit, so the npm postinstall phase also work on Windows node installations
Rebase of #1266