Skip to content

[RFR] Fix error messages on failed deletes, updates#1197

Merged
jpetitcolas merged 1 commit intomasterfrom
error_message_on_failed_delete
Oct 11, 2016
Merged

[RFR] Fix error messages on failed deletes, updates#1197
jpetitcolas merged 1 commit intomasterfrom
error_message_on_failed_delete

Conversation

@jpetitcolas
Copy link
Copy Markdown
Contributor

No description provided.

@jpetitcolas
Copy link
Copy Markdown
Contributor Author

jpetitcolas commented Sep 19, 2016

Closes #1130.

@RichardBradley
Copy link
Copy Markdown
Contributor

(It doesn't close all of #1129, just makes it better. See comments on #1130)

@Phocea
Copy link
Copy Markdown
Contributor

Phocea commented Oct 11, 2016

@jpetitcolas do you have an ETA on this merge by any chance ?

@jpetitcolas jpetitcolas merged commit c4ab78d into master Oct 11, 2016
@jpetitcolas jpetitcolas deleted the error_message_on_failed_delete branch October 11, 2016 15:10
@jpetitcolas
Copy link
Copy Markdown
Contributor Author

@Phocea: a few seconds ago. :)

@Phocea
Copy link
Copy Markdown
Contributor

Phocea commented Oct 12, 2016

works a treat, much better.
Do you think this one could also be merged #1223 so we also get the error message displayed correctly when happening on state change?

Will open another PR later with a way to configure the redirect depending on the http code error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants