Skip to content

[RFR] Fix non-dev dependencies#1189

Merged
fzaninotto merged 11 commits intomasterfrom
dependencies
Sep 19, 2016
Merged

[RFR] Fix non-dev dependencies#1189
fzaninotto merged 11 commits intomasterfrom
dependencies

Conversation

@jpetitcolas
Copy link
Copy Markdown
Contributor

@jpetitcolas jpetitcolas commented Sep 12, 2016

As it breaks other projects because of missing dependencies (for instance admin-config one).

Still in WIP as I am testing it on a project rewrite.

jpetitcolas
jpetitcolas reviewed Sep 13, 2016
View reviewed changes
package.json
"angular-translate": "^2.11.0",
"angular-ui-bootstrap": "~1.2.1",
"angular-ui-codemirror": "^0.3.0",
"angular-ui-codemirror": "jpetitcolas/ui-codemirror#di",
Copy link
Copy Markdown
Contributor Author

@jpetitcolas jpetitcolas Sep 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix some strict DI errors, preventing JSON field to be colored.

@jpetitcolas
Copy link
Copy Markdown
Contributor Author

jpetitcolas commented Sep 13, 2016

Should be fine now. Can someone give it a try using this branch?

@jpetitcolas jpetitcolas mentioned this pull request Sep 14, 2016
Merged
3 tasks
@Phocea
Copy link
Copy Markdown
Contributor

Phocea commented Sep 15, 2016

Happy to report that I did not face any more issues using this branch!

Since I am also using webpack and babel. I also managed to make this work without the transpiled libs, by using an alias and including the source of ng-admin.
If you think this is worth mentioning I will gladly add this to the documentation once this branch is merged.
Thanks @jpetitcolas !

@jpetitcolas
Copy link
Copy Markdown
Contributor Author

jpetitcolas commented Sep 15, 2016

@Phocea: Glad to read it! :)

I voluntarily did not mention it. Indeed, if you use Babel, you can either use src/ (ES6 files) or lib/ (ES5 files). But if you don't, you can still use ES5. And as this is the default location of the lib (at least once published on npm), it should be fine.

@fzaninotto: switching it to RFR. We should release an alpha5.1 ASAP if everything is fine for you.

@jpetitcolas jpetitcolas changed the title [WIP] Fix non-dev dependencies [RFR] Fix non-dev dependencies Sep 15, 2016
@jpetitcolas jpetitcolas added this to the 1.0 milestone Sep 19, 2016
fzaninotto
fzaninotto reviewed Sep 19, 2016
View reviewed changes
webpack.config.js Outdated
@@ -1,4 +1,5 @@
var ExtractTextPlugin = require('extract-text-webpack-plugin');
var path = require('path');
Copy link
Copy Markdown
Member

@fzaninotto fzaninotto Sep 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not used

@fzaninotto fzaninotto merged commit cc21984 into master Sep 19, 2016
@fzaninotto fzaninotto deleted the dependencies branch September 19, 2016 07:23
@fzaninotto fzaninotto mentioned this pull request Sep 19, 2016
Closed
@Kmaschta Kmaschta mentioned this pull request Nov 18, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fzaninotto fzaninotto fzaninotto left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@jpetitcolas @Phocea @fzaninotto @RichardBradley