It would be great to test that progression.start() and progression.done() are called correctly in the controller (in both case of success and case of error).

👍

@jpetitcolas this can only be done in an e2e test (because the done() is called in the resolve phase of the next route), and is very hard to test due to timing issues.

It is left as an exercise for the reader.

review applied

Thanks @fzaninotto for contributing to marmelab open-source projects!
As a sign of our gratitude, you can publish an image to advertise your brand on the marmelab website for a whole day.
Head to this page to submit your image. It will appear on Zero Dollar Homepage, powered by blockchain technology.