Skip to content

[FIX] wording typo (Typo in Documentation #1078)#1081

Merged
fzaninotto merged 1 commit intomarmelab:masterfrom
bestori:master
May 25, 2016
Merged

[FIX] wording typo (Typo in Documentation #1078)#1081
fzaninotto merged 1 commit intomarmelab:masterfrom
bestori:master

Conversation

@bestori
Copy link
Copy Markdown
Contributor

@bestori bestori commented May 23, 2016

Good catch, cfatt10 :)

@bestori
Copy link
Copy Markdown
Contributor Author

bestori commented May 23, 2016

CI fails have nothing to do with commit..

@bestori bestori mentioned this pull request May 23, 2016
@cfatt10
Copy link
Copy Markdown

cfatt10 commented May 24, 2016

Thanks for making the pull request! It looks like you actually found another spot where 'literal' was misspelled. The original sentence was

When given an array, each choice must be an object litteral with both a value and a label.

And the sentence you found is

Symmetrically, passing an object litteral as argument to the setter methor view.fields(fields) is deprecated ;

See issue #1078 for location of first sentence

@bestori
Copy link
Copy Markdown
Contributor Author

bestori commented May 25, 2016

Actually, the one you specified appears fixed on my pull :)
Any idea why the checks are consistently failing?
it appears as though it's the status of the current version...?

@fzaninotto fzaninotto merged commit 97460f1 into marmelab:master May 25, 2016
@marmelab-bot
Copy link
Copy Markdown
Contributor

Thanks @bestori for contributing to marmelab open-source projects!
As a sign of our gratitude, you can publish an image to advertise your brand on the marmelab website for a whole day.
Head to this page to submit your image. It will appear on Zero Dollar Homepage, powered by blockchain technology.

@fzaninotto
Copy link
Copy Markdown
Member

Thanks! I don't understand why tests fail on travis, it's unrelated to your change.

@bestori
Copy link
Copy Markdown
Contributor Author

bestori commented May 25, 2016

Thanks! 👍 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants