This repository was archived by the owner on Jun 27, 2018. It is now read-only.
Merged
Conversation
fzaninotto
force-pushed
the
map_transform
branch
from
bbe95ea to
e41bc75
Compare
- map() turns a JS object to an entry - transform() turns an entry into a JS object Moved the map logic to fields and views, removed it from Entry and Datastore
fzaninotto
changed the title
Member
Author
|
Switching to RFR |
jeromemacias
added a commit
that referenced
this pull request
Jul 9, 2015
[RFR] Clarify the map() logic
Member
Author
|
Note that these changes will cause warnings in react-admin until the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
new Field('foo.bar'))This is not a BC break, but it deprecates
DataStore.mapEntry()andDataStore.mapEntries(), in favor ofEntry.createFromRest(restEntry)andentry.transformToRest(). Will log warnings about the deprecation.Required for marmelab/ng-admin#549