This repository was archived by the owner on Jun 27, 2018. It is now read-only.
[RFR] Add parameter in View.getReferences to filter on refreshDelay#19
Merged
jeromemacias merged 5 commits intomasterfrom Jun 26, 2015
Merged
[RFR] Add parameter in View.getReferences to filter on refreshDelay#19jeromemacias merged 5 commits intomasterfrom
jeromemacias merged 5 commits intomasterfrom
Conversation
jpetitcolas
changed the title
Contributor
Author
|
Back to WIP. As seen with @fzaninotto, we will use an |
Contributor
Author
|
Switching to RFR. @fzaninotto, I added two methods |
jpetitcolas
changed the title
Contributor
Author
|
After more discussions, still wrong naming. We are going to use |
jpetitcolas
changed the title
Contributor
Author
|
Back to RFR. |
jpetitcolas
changed the title
lib/Queries/ReadQueries.js
Outdated
9 tasks
lib/View/View.js
Outdated
Contributor
There was a problem hiding this comment.
I think you should rename withRefreshDelay to withRemoteComplete.
Contributor
Author
|
Reviewed |
jeromemacias
added a commit
that referenced
this pull request
Jun 26, 2015
[RFR] Add parameter in View.getReferences to filter on refreshDelay
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Useful to prevent from doing an extra request at route resolving on ng-admin (see marmelab/ng-admin#508).