Skip to content
This repository was archived by the owner on Jun 27, 2018. It is now read-only.

[RFR] enable batchDeleteView by default#12

Merged
jeromemacias merged 1 commit intomasterfrom
enable_batch_delete_view
Jun 10, 2015
Merged

[RFR] enable batchDeleteView by default#12
jeromemacias merged 1 commit intomasterfrom
enable_batch_delete_view

Conversation

@ThieryMichel
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this will not break anything on existed projects ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the contrary, it fix thing. This view does not need field, and if none were added to it, a view is not enabled error is thrown.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the batch-delete actions is disablable by using the batchActions method on the list view.

jeromemacias added a commit that referenced this pull request Jun 10, 2015
[RFR] enable batchDeleteView by default
@jeromemacias jeromemacias merged commit 9c873f6 into master Jun 10, 2015
@jeromemacias jeromemacias deleted the enable_batch_delete_view branch June 10, 2015 07:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants